Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1225739pxf; Fri, 9 Apr 2021 03:17:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwl2z1bOxH27F0+yhgFP77EI+zP3EmSwWayFtg8UwW/pY7kj8rcGP8rUZKRfdaRAJ7up7v3 X-Received: by 2002:a17:906:430f:: with SMTP id j15mr15618190ejm.543.1617963458629; Fri, 09 Apr 2021 03:17:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617963458; cv=none; d=google.com; s=arc-20160816; b=IRG/gKtxrUUdDhcU8F7GS5L0fRu3ajbXogN9sM52qyfxHpOPmAxMZnpzV5CMDy/wm2 N91/5s8G/FJxotu7WHiP/gnoRa9EuNf9z80zOhe11iecAwaVHPQdG59FFXC+g1IG8Kfl AG3XPif0wSiS3zE0iVBM0fnuSXdIkecE4k7tWP9NU2p7a93mhfFdHkuksZrlf4nv5hNM 1dYj2QhSpqKst5MI4RrbkwDIKpNV6iNJoQtxPXZkuoOeVwdldxHUUKBS1rbPngghDGV3 UDceoJyeT5rhjinJBaVoRJb1Ll/qvRRbQrNdVKLuRcvCWjIx/6iidi3f6nno5uwTjnjv 84mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8B4MkngwfsCvuEu80iznXxlP/l6HckkwFKsS/CCX14g=; b=VaTJw/cvVxI6gctlosq2pesmsZ8QWZdU1no0n+X7qZk9BXIsigs4qobot1amFGO3Cn SQwueHAf4D4FIWVy0KmJ3C3isJECNRxpZbB3XQn2FqqGcMtGhd6v9qJZBNfHcxwroDH+ +yi+15i4/mDqavjo1tf31BJEeI+T4egCetIdlrFSWJWZ0GYs9QMfjBt3x80RTyL/ifjs dY/3ucBA1wh9r/7ae+B1rXzzIfrNX1CSGGpglBSnVc4ooIcYX81C5fTkzAvi/Ewg8l6O WzoB/F76cDICmIIo44g7yZ3/1MNC6e62Ioe798I4JcUKZ/K6WXUuglq3v/5mw8zmhgMy VCiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WDlw6EFG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g25si1679041edm.585.2021.04.09.03.17.15; Fri, 09 Apr 2021 03:17:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WDlw6EFG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234397AbhDIKOY (ORCPT + 99 others); Fri, 9 Apr 2021 06:14:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:51586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234209AbhDIKFM (ORCPT ); Fri, 9 Apr 2021 06:05:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 048F261352; Fri, 9 Apr 2021 10:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617962493; bh=zbUYVA0Aak82mjeAyjKw0nf0XfPsh2sO9uhwAHHAEu8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WDlw6EFGwQFvzGJrHqMyX5U7JbfJEX/WmzD6XQbBCUO6PIaHkJ3O/aywCNKEqpDAA 8hwTMlLogwlJEFKoJRjdVeggaDKwYToS+f5hF3+x+QeTDtqsaTCSVuqWlmeKq2o1cJ 2DKIQf6ZE8Y8y77RTK1ofcq1pv6RpitprkGdpxr4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tariq Toukan , Maxim Mikityanskiy , Saeed Mahameed , Sasha Levin Subject: [PATCH 5.11 06/45] net/mlx5e: Enforce minimum value check for ICOSQ size Date: Fri, 9 Apr 2021 11:53:32 +0200 Message-Id: <20210409095305.596128291@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210409095305.397149021@linuxfoundation.org> References: <20210409095305.397149021@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tariq Toukan [ Upstream commit 5115daa675ccf70497fe56e8916cf738d8212c10 ] The ICOSQ size should not go below MLX5E_PARAMS_MINIMUM_LOG_SQ_SIZE. Enforce this where it's missing. Signed-off-by: Tariq Toukan Reviewed-by: Maxim Mikityanskiy Reviewed-by: Saeed Mahameed Signed-off-by: Saeed Mahameed Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index aaa5a56b44c7..b6324d11a008 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -2317,8 +2317,9 @@ static u8 mlx5e_build_icosq_log_wq_sz(struct mlx5e_params *params, { switch (params->rq_wq_type) { case MLX5_WQ_TYPE_LINKED_LIST_STRIDING_RQ: - return order_base_2(MLX5E_UMR_WQEBBS) + - mlx5e_get_rq_log_wq_sz(rqp->rqc); + return max_t(u8, MLX5E_PARAMS_MINIMUM_LOG_SQ_SIZE, + order_base_2(MLX5E_UMR_WQEBBS) + + mlx5e_get_rq_log_wq_sz(rqp->rqc)); default: /* MLX5_WQ_TYPE_CYCLIC */ return MLX5E_PARAMS_MINIMUM_LOG_SQ_SIZE; } -- 2.30.2