Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date:   Fri, 09 Apr 2021 13:19:28 +0300
From:   Nick Kossifidis <mick@ics.forth.gr>
To:     Alex Ghiti <alex@ghiti.fr>
Cc:     Nick Kossifidis <mick@ics.forth.gr>,
        linux-riscv@lists.infradead.org, palmer@dabbelt.com,
        paul.walmsley@sifive.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] RISC-V: Add kexec support
Organization: FORTH
In-Reply-To: <386bf260-006a-62c4-2d7b-1a22a43b3513@ghiti.fr>
References: <20210405085712.1953848-1-mick@ics.forth.gr>
 <20210405085712.1953848-3-mick@ics.forth.gr>
 <386bf260-006a-62c4-2d7b-1a22a43b3513@ghiti.fr>
Message-ID: <3c821aaf141651f5c58c84bb0f294e9b@mailhost.ics.forth.gr>
User-Agent: Roundcube Webmail/1.3.16
Precedence: bulk

Στις 2021-04-06 21:38, Alex Ghiti έγραψε:
> Le 4/5/21 à 4:57 AM, Nick Kossifidis a écrit :
>> +
>> +/* Reserve a page for the control code buffer */
>> +#define KEXEC_CONTROL_PAGE_SIZE 4096
> 
> PAGE_SIZE instead ?
> 

Yup, I'll change it.

>> +obj-${CONFIG_KEXEC}		+= kexec_relocate.o machine_kexec.o
> 
> Other obj-$() use parenthesis.
> 

ACK

>> +	li	s5, ((1 << PAGE_SHIFT) / RISCV_SZPTR)
> 
> 1 << PAGE_SHIFT = PAGE_SIZE
> 

ACK

>> +#if defined(CONFIG_HOTPLUG_CPU) && (CONFIG_SMP)
> 
> Shouldn't it be defined(CONFIG_SMP) ?
> 

It depends on SMP anyway, I'll remove the second part.