Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210407160927.222092-1-lucjan.lucjanov@gmail.com> <20210408210448.1850553-1-lucjan.lucjanov@gmail.com>
In-Reply-To: <20210408210448.1850553-1-lucjan.lucjanov@gmail.com>
Reply-To: sedat.dilek@gmail.com
From:   Sedat Dilek <sedat.dilek@gmail.com>
Date:   Fri, 9 Apr 2021 12:30:56 +0200
Message-ID: <CA+icZUVnrNJ2=LYF_mre6npUvGHP8xAxdAAipLN_sQEvsK0wmg@mail.gmail.com>
Subject: Re: Subject: Re: [PATCH v3] kbuild: add support for zstd compressed modules
To:     Piotr Gorski <lucjan.lucjanov@gmail.com>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        masahiroy@kernel.org, oleksandr@natalenko.name
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Apr 8, 2021 at 11:05 PM Piotr Gorski <lucjan.lucjanov@gmail.com> wr=
ote:
>
> No, the --rm option is essential. xz and gzip have the --rm option built =
in as opposed to zstd, which is why I used it. I've been using zstd module =
compression since last december (although I set a different compression lev=
el on mine) and everything works fine. Oleksandr also tested it at his plac=
e and didn't report any objections.

[ CC me I am not subscribed to linux-kbuild or linux-kernel ]
[ CC Nick ]

Unfortunately, I do not find my initial posting which has all information.
I add the link to the thread on linux-kbuild ML.

So, I gave you as much information as I have (linux-config, make-line
etc.) and you write "everything works fine"?
What do you mean by "everything" - different compressors and none?
Is that working "fine"?

What build environment do you use?
Here: Debian/testing AMD64.

Did you try with...

CONFIG_DEBUG_INFO=3Dy
CONFIG_DEBUG_INFO_DWARF5=3Dy
CONFIG_MODULE_COMPRESS_ZSTD=3Dy

...Kconfigs enabled?

As said I use builddeb from scripts directory to generate my Debian package=
s.
Any chance you can test with builddeb?

I have enabled Clang-LTO Kconfig.
Tried with Clang-LTO Kconfig?

This worked *before* and *after*...

kbuild: add support for zstd compressed modules
kbuild: remove CONFIG_MODULE_COMPRESS (CC Nick as he is listed as a
reviewer here)

... not within my build-environment.
For me this is a *regression*.

- Sedat -

[1] https://marc.info/?t=3D161790914600002&r=3D1&w=3D2