Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1255721pxf; Fri, 9 Apr 2021 04:09:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypDM2TjCDfHv3lOHDyEKYMlJpzPaCi+jEb8BlA1oR1OfXM92PpOpS6879KLrSy5yjoWpHi X-Received: by 2002:a17:906:9385:: with SMTP id l5mr7050307ejx.32.1617966566202; Fri, 09 Apr 2021 04:09:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617966566; cv=none; d=google.com; s=arc-20160816; b=pFpbDTeirgCSAYJ3Ysf/1tEl3Rebw1XRyeECb5RP0y5CWX5f9gJ+mQk3oTZsPfPuLI bFppsB8FjTLJ2drYYxu7JNnowqh9CUOZ/6e4TRInLHNzsBnqKBQ/r9R48UHq/vkMLADJ 2Hn6kA7l4GmPlTOQV4hT+PVsqhnWRyzgMukw2LOCkkO60wwmNotZNETLmEHlSrt0E/+b M1bmBmSkMfK3kuZIScOWeWs0M0d+1DxarEq2vvkOX6rPcEH831+lENE42DndV/UVlR1T XePdKPrnZXOFpcZTwFLIcg8QQ9L2EXRIo7Wp+tjT8JspLzkftuZ+2otCWWGlweD3ucDt S6xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=uBRmHCuX0HR5t4Oqmpr7Nzemqe0bG44m+1eHZXB2lFE=; b=TBLEmguK+iJps/Rmc5QjqqdZQPHHk3RpOdC7DJMcpM84FcLJeCQq2Vw1AeMTutjdHx dwQSvQ99XYclxrmPoP5buFAJl62UZm3jAsAQhBXL7vw/kjIBR9rRcEDuPW/Mqj8bdM/I JbrjGzTxZBjBZLJT+Xg2F1MaoC1THkqH0DNRONGblTrKq59/6WXaVFXdUoCgr/6YwE3p pzfHWju4ywKg8ng7kkPbIavAQFEeE2a69PoGzwJoXpmfjjMinPC5Bco/PVY6jQx1e3fq 0onKOwF/Q1eVygAMeGMNBs2twHK2+2I/HgBrehTU+5ekpSWL0y9si1+S3UcGK0IuZ2ZL /oAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dk18si1957594edb.570.2021.04.09.04.09.03; Fri, 09 Apr 2021 04:09:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233780AbhDILIQ (ORCPT + 99 others); Fri, 9 Apr 2021 07:08:16 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:15654 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233682AbhDILIP (ORCPT ); Fri, 9 Apr 2021 07:08:15 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FGwJn1zNXzpWyb; Fri, 9 Apr 2021 19:05:13 +0800 (CST) Received: from DESKTOP-EFRLNPK.china.huawei.com (10.174.176.196) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.498.0; Fri, 9 Apr 2021 19:07:55 +0800 From: Qiheng Lin To: , Jassi Brar CC: , , "Hulk Robot" Subject: [PATCH -next] mailbox: arm_mhu_db: Remove redundant dev_err call in mhu_db_probe() Date: Fri, 9 Apr 2021 19:07:54 +0800 Message-ID: <20210409110754.155-1-linqiheng@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.176.196] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Qiheng Lin --- drivers/mailbox/arm_mhu_db.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mailbox/arm_mhu_db.c b/drivers/mailbox/arm_mhu_db.c index 8eb66c4ecf5b..9e9c1261da2a 100644 --- a/drivers/mailbox/arm_mhu_db.c +++ b/drivers/mailbox/arm_mhu_db.c @@ -278,10 +278,8 @@ static int mhu_db_probe(struct amba_device *adev, const struct amba_id *id) return -ENOMEM; mhu->base = devm_ioremap_resource(dev, &adev->res); - if (IS_ERR(mhu->base)) { - dev_err(dev, "ioremap failed\n"); + if (IS_ERR(mhu->base)) return PTR_ERR(mhu->base); - } chans = devm_kcalloc(dev, max_chans, sizeof(*chans), GFP_KERNEL); if (!chans)