Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1270867pxf; Fri, 9 Apr 2021 04:33:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwlzCL1zwSfT2/62c+P0ToCNIS9C1eI5XFRhHShnjTe2YV34TplYcjlrAhxsJ4n3AJ4JHZ X-Received: by 2002:a65:6493:: with SMTP id e19mr12544565pgv.161.1617967982346; Fri, 09 Apr 2021 04:33:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617967982; cv=none; d=google.com; s=arc-20160816; b=Qa1CHOE5s/urRr9sJRUtZSA04YosjMe8ViVq0H/28FnDwGqdN0M0V7xOpi3MGh2ujl Ox19z4p9E7ok97OJya8+qlD3iMSrJ2rH2fznYA4Qmru12Ug16mgT/2U+vh6KH3hwEE3n oNty4Imgi9DWOf3z+v2OMgbTyyc+QnRQoFikLEj4VHCNUsjPR7hyg7nGRq9nIseua2Gm gsy4IRKM5aQuSKWt6daaIE/3TjJx8m2KwEBzpjtAzi8gaZzhkcMKenFOyVup3HwByc7p 6LcMug6pIMyQhtfYMJIJ5jbz9aNW0hS6EuoK6eyoLyRxeZkXt/qAYplyv+E1A2squuvk vvFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=yWycNcX0JdLVzMu4Wozww3tYBFcxvyLw3rhDiPYVTyc=; b=hOJ3rLYnCTsdPv/QI748ks/2dW8N2S5r7+FXUoYiQ/G53W6h+nddCrngt7em0Hor6h EW56PhLNOxS8JWl0K2IRvb26Ou0KdS+qZSEpu6Io6zw2QooaNHgGIdRoIIBwVIGfhngi H6GSkbPih1000VbW/B38LU1+FXA5qYJsx4+IVRgQuQv365kv4fn8Xm5bziYYrAvxq5kx 5ZuMG7kacCxM8H4fl4eHJchNp40f82t0eQTaaX61AYgY2+A4zQN5pj4dsYXc9CtZyX7W 9XiydC5UDEq6u4awbJ54JL6prgXAYFbLKTS50ldIeJSWrrPkPwpVphHKJxdcOruFEZPy H++g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=trVdlCtf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u20si2897490pgj.137.2021.04.09.04.32.49; Fri, 09 Apr 2021 04:33:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=trVdlCtf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232990AbhDILbf (ORCPT + 99 others); Fri, 9 Apr 2021 07:31:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:46788 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233532AbhDILbc (ORCPT ); Fri, 9 Apr 2021 07:31:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 59CDA6113A; Fri, 9 Apr 2021 11:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617967879; bh=fUp0KpjNQFEeNM0zf+0A70wkSLLCHLMN8TUpFFkE/Ck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=trVdlCtfHEy41zGKMjob9ykuUD1Qjq3pGi4wPcrTsBrFrBpoFV4awRihVWa74ZlUO X8kaF5+9MazVIiXDLCW92DCjcVcZhoDXenOHyyH8bDyOy/4tZt+xBDGsJI36vTfVnp dtPmATsLtylovnLwq/Qhe4BxlcaKrL+UcXG7xFxmrb1U+FMYLHlqXxug7EcXWAiPN/ CW3vRWtgmbSTOe2BfHgpeNOODK74yeOtJYAcLf2e7NFmxBNbK8a6Fg/rA0FkeitLoy veTNJZoy0kbq0iKhae8l+lS7xLcGeHBDFkpUAvmmKlydcStoSjq5o47c4jzqFElZPA X95ZXrN1eLITw== Date: Fri, 9 Apr 2021 12:31:01 +0100 From: Mark Brown To: "Madhavan T. Venkataraman" Cc: mark.rutland@arm.com, jpoimboe@redhat.com, jthierry@redhat.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 3/4] arm64: Detect FTRACE cases that make the stack trace unreliable Message-ID: <20210409113101.GA4499@sirena.org.uk> References: <705993ccb34a611c75cdae0a8cb1b40f9b218ebd> <20210405204313.21346-1-madvenka@linux.microsoft.com> <20210405204313.21346-4-madvenka@linux.microsoft.com> <20210408165825.GP4516@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xHFwDpU9dbj6ez1V" Content-Disposition: inline In-Reply-To: X-Cookie: Ring around the collar. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xHFwDpU9dbj6ez1V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 08, 2021 at 02:23:39PM -0500, Madhavan T. Venkataraman wrote: > On 4/8/21 11:58 AM, Mark Brown wrote: > > This looks good to me however I'd really like someone who has a firmer > > understanding of what ftrace is doing to double check as it is entirely > > likely that I am missing cases here, it seems likely that if I am > > missing stuff it's extra stuff that needs to be added and we're not > > actually making use of the reliability information yet. > OK. So, do you have some specific reviewer(s) in mind? Apart from yourself, Mark Rutland and > Josh Poimboeuf, these are some reviewers I can think of (in alphabetical order): Mainly Mark Rutland, but generally someone else who has looked at ftrace on arm64 in detail. It was mainly a comment to say I wasn't going to do any kind of Reviewed-by but also hadn't spotted any issues. --xHFwDpU9dbj6ez1V Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBwOvQACgkQJNaLcl1U h9C1ywf/Zbw1Z1QFQ9f8u2MHhFttf12fqFoSFd5iqQ9spEcbfaBlpTl2v8M/5H9h R6oBURNPeVfVCxvv/71t9Orzqyn9ARMB/OizAb2stUPdlFcnKAYcK+EGhOLqLKvu ROhmYPrJxYkjx9Qegny0xAZp5MrlJ6nmUDl8xOLJYYj706CxMFP5Ajsbx+iYk1ZE s3sEJFrMhNTcQGo/Ov6u8icSdzC5GmdnbLZLZQABGM2XGtLYaI4OEAg9ZwXD/fIK A97q5N6unW1DVvNGwOdKRGakFGw/B9JoLtSEvWjEpsDzePbgTOm5hiWQi1GZNR51 9te0IeS7HVke1UH7AXxDqXJPHrbPLg== =neW0 -----END PGP SIGNATURE----- --xHFwDpU9dbj6ez1V--