Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1284245pxf; Fri, 9 Apr 2021 04:55:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuNVZZ6taPc0zOeFhgfpNhiZMeQzJMI8oT2Sf+J21FuKecqqxSx3QFY5qrdqvO13A6Ewke X-Received: by 2002:a17:907:3f20:: with SMTP id hq32mr8607333ejc.226.1617969335713; Fri, 09 Apr 2021 04:55:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617969335; cv=none; d=google.com; s=arc-20160816; b=nEsie1GhVRXS000vwwH+QQCueXm1Bf1UsL3VZpffEFek5KLI/IVJflIZk3QWLXjdVR YMovBps5KlBZMrPcfkDF+DBjplwDc4kIchfBu99iPRYAFpWoTyoB4WCVYQFcJoFSX0D4 4DSIWK3Dwko63LhSrBlyIUNm7m3NClGo/8niE4eAOCUZ87TXHVDkjZnjnxFFvu6dB9Go 5bN76iJpNlbqzHgSoEZQfLh8HG2IAS8hnpgqp28S1rWK/ZtxlukkXS3qnd4hO2G+K0F9 4LrfEforzl68NVdje+k9XKAyrUAJjCcaEssaAcRox6xyYZojzG8siPXTRxQcuw2KibWP URpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=2k7PWCGZRUOJsTyXPv/QjipwXhH3zQQhXE+2zw0Drpg=; b=gbPEBKM3bLvEAp0CfzMA890IgI62nSSJTIbzfHy1E354GTdodDc8btgt8q1ytq9u7Y TjI6ESA6yQzRF7a/IhyJWEX/mw0GLcs0mlmuyPBMupyO29m52zM1XxOQGeh2/+zmK8LO ufiFdX5ykWESYcyZhN0lTOGQ01yCQpqxp+3zgFQplpl6g9TMRqiaVAGwxzhXpkSKDPkJ 4Pa5ygtXHcBHKmyAXxGLY1wdLrEqi9zfOY0GM/O2Mu36aFlEs2x/Aapndve5ybvyIcCW P4fptXRATwXigQFLkoCIECMjBcZGvP006Zslj6fwnuLvkYIQ/Chrs7yVSKkGEGPvHZfH 0S8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s18si2047002edc.122.2021.04.09.04.55.13; Fri, 09 Apr 2021 04:55:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233856AbhDILyU (ORCPT + 99 others); Fri, 9 Apr 2021 07:54:20 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:16864 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233548AbhDILyU (ORCPT ); Fri, 9 Apr 2021 07:54:20 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FGxLc0DBnz9x87; Fri, 9 Apr 2021 19:51:52 +0800 (CST) Received: from DESKTOP-EFRLNPK.china.huawei.com (10.174.176.196) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Fri, 9 Apr 2021 19:53:55 +0800 From: Qiheng Lin To: , CC: , , , Qiheng Lin Subject: [PATCH net-next] cxgb4: remove unneeded if-null-free check Date: Fri, 9 Apr 2021 19:53:39 +0800 Message-ID: <20210409115339.4598-1-linqiheng@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Originating-IP: [10.174.176.196] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eliminate the following coccicheck warning: drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c:529:3-9: WARNING: NULL check before some freeing functions is not needed. drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c:533:2-8: WARNING: NULL check before some freeing functions is not needed. drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c:161:2-7: WARNING: NULL check before some freeing functions is not needed. drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c:327:3-9: WARNING: NULL check before some freeing functions is not needed. Signed-off-by: Qiheng Lin --- drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c | 3 +-- drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c | 3 +-- drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c | 8 ++------ 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c index ce28820c57c9..12fcf84d67ad 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c +++ b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c @@ -323,8 +323,7 @@ void t4_cleanup_clip_tbl(struct adapter *adap) struct clip_tbl *ctbl = adap->clipt; if (ctbl) { - if (ctbl->cl_list) - kvfree(ctbl->cl_list); + kvfree(ctbl->cl_list); kvfree(ctbl); } } diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c index 77648e4ab4cc..dd66b244466d 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c @@ -157,8 +157,7 @@ static int cudbg_alloc_compress_buff(struct cudbg_init *pdbg_init) static void cudbg_free_compress_buff(struct cudbg_init *pdbg_init) { - if (pdbg_init->compress_buff) - vfree(pdbg_init->compress_buff); + vfree(pdbg_init->compress_buff); } int cxgb4_cudbg_collect(struct adapter *adap, void *buf, u32 *buf_size, diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c index dede02505ceb..a5d2f84dcdd5 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c @@ -524,13 +524,9 @@ struct cxgb4_tc_u32_table *cxgb4_init_tc_u32(struct adapter *adap) out_no_mem: for (i = 0; i < t->size; i++) { struct cxgb4_link *link = &t->table[i]; - - if (link->tid_map) - kvfree(link->tid_map); + kvfree(link->tid_map); } - - if (t) - kvfree(t); + kvfree(t); return NULL; } -- 2.31.1