Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: JA53T9zrfEtXKw0Zk6CRz2ZsANOI12L2tTxiO2eJOboeQkX7ZuBHJ514nrFacUpCx02LnvrxHk
 87luaRcDR7qiiKyljx9CCUMElxIWEKDSOLLPmMyew5bDRNjhJljv99XuZwl7jEnvXImMni1HwO
 Tx3JpgenGqvLj7W7hONYclOuF9VBVz7jXB+3ZxaJ/G9Ddo3cZgu45pdzUqWDazvvULQnzY12Qd
 oQb1FIqd+xK4kfQs97MZJH0SNvIHZmwmFzDtH0dNRTL1Rke9UovSK5vPulV1Y3YxzUl4yFuQ16
 /9E=
From:   <Ludovic.Desroches@microchip.com>
To:     <Tudor.Ambarus@microchip.com>
CC:     <linus.walleij@linaro.org>, <Claudiu.Beznea@microchip.com>,
        <Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: at91-pio4: Fix slew rate disablement
Thread-Topic: [PATCH] pinctrl: at91-pio4: Fix slew rate disablement
Thread-Index: AQHXLRnq9RpxBsB7oU+h+ykUgcKl36qsGKOA
Date:   Fri, 9 Apr 2021 12:11:08 +0000
Message-ID: <20210409121107.mcjo6cbsequjd3v4@sekiro>
References: <20210409082522.625168-1-tudor.ambarus@microchip.com>
In-Reply-To: <20210409082522.625168-1-tudor.ambarus@microchip.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <85BA562FCFCBD44C95621F4F6C025A7C@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 68be5f5e-b187-4b8e-0c47-08d8fb508f16
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2021 12:11:08.8068
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KG0pB6vVtEdkk6VgGPnqBX6KcAAcyI8l4cbK3YGOgg29yXvtr11dLmPbsEIC6J6NVPP4j0dZjqwXH4QSzsQ7laTW6UswSba3M1t8Wo0yNdA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3083
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 09, 2021 at 11:25:22AM +0300, Tudor Ambarus wrote:
> The slew rate was enabled by default for each configuration of the
> pin. In case the pin had more than one configuration, even if
> we set the slew rate as disabled in the device tree, the next pin
> configuration would set again the slew rate enabled by default,
> overwriting the slew rate disablement.
> Instead of enabling the slew rate by default for each pin configuration,
> enable the slew rate by default just once per pin, regardless of the
> number of configurations. This way the slew rate disablement will also
> work for cases where pins have multiple configurations.
>=20
> Fixes: 440b144978ba ("pinctrl: at91-pio4: add support for slew-rate")
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>

Thanks.

> ---
>  drivers/pinctrl/pinctrl-at91-pio4.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctr=
l-at91-pio4.c
> index a5d328808e4c..4c01d8471ffa 100644
> --- a/drivers/pinctrl/pinctrl-at91-pio4.c
> +++ b/drivers/pinctrl/pinctrl-at91-pio4.c
> @@ -801,6 +801,10 @@ static int atmel_conf_pin_config_group_set(struct pi=
nctrl_dev *pctldev,
> =20
>  	conf =3D atmel_pin_config_read(pctldev, pin_id);
> =20
> +	/* Keep slew rate enabled by default. */
> +	if (atmel_pioctrl->slew_rate_support)
> +		conf |=3D ATMEL_PIO_SR_MASK;
> +
>  	for (i =3D 0; i < num_configs; i++) {
>  		unsigned int param =3D pinconf_to_config_param(configs[i]);
>  		unsigned int arg =3D pinconf_to_config_argument(configs[i]);
> @@ -808,10 +812,6 @@ static int atmel_conf_pin_config_group_set(struct pi=
nctrl_dev *pctldev,
>  		dev_dbg(pctldev->dev, "%s: pin=3D%u, config=3D0x%lx\n",
>  			__func__, pin_id, configs[i]);
> =20
> -		/* Keep slew rate enabled by default. */
> -		if (atmel_pioctrl->slew_rate_support)
> -			conf |=3D ATMEL_PIO_SR_MASK;
> -
>  		switch (param) {
>  		case PIN_CONFIG_BIAS_DISABLE:
>  			conf &=3D (~ATMEL_PIO_PUEN_MASK);
> --=20
> 2.25.1
> =