Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1305435pxf; Fri, 9 Apr 2021 05:24:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPQWFdNGObbIOh4dKDmpdzqKFDgJQU9LdSwlWq6SK0XxLlt/wGUrMx0kCHDm2yv7j8mui/ X-Received: by 2002:a17:902:6949:b029:e8:c22d:17ae with SMTP id k9-20020a1709026949b02900e8c22d17aemr12255830plt.57.1617971041316; Fri, 09 Apr 2021 05:24:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617971041; cv=none; d=google.com; s=arc-20160816; b=YtoYOrBkamG4MCGktDY89PE4JPgZd8CN42FX3Mf4n7HoqPmGpFf6VSAzzx4y2rWlY8 cxHFlYS+Q0UQLgW77V8fx8POmP+WvDtxf7HIB9t3RxBHBbM7ZjdLjg5YlgW8h79NCkaq nCAcpcP2AesHT57ZH0yZqXE4vnDkyEGNvecnHXRLnkn2gcXacyDxUjOSPY88kyC587Kq ZeHFqPQes81mkvnCbyG+i2WnKqn0S3mdmMlgHLWQoaWhxlQhJ9MjJ6YLzedDo1U7vp6n FkxYDG487RLXdzSPaytHoG9pFGRjxWF7twhUETg/P+jJLLbc6YfOD7jWP/zdETsWBmau 0ILw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=neZIICAFpa89ivmiPrzNjdLAyh87CRpeucaxzPaySRY=; b=Cvb0wWmpmP6JcCI1bES9g8N/gfLh+DTQLYOhkqFV7uKIJDb9IqBjAhXEcrgcZsryMf m+1++pzcxFTarOTyIcqMyl97kDz4+o2iacIG47RABHvz2bLwWtoYha0RwClExKeDKhQq h3Q3cvc6zRMM4rToTMVVguSJ3TL09zEGBUb4Zkai5R1Y8vLGKh9R4eB432aESwWWeLDZ rAsLvNEWg2TEQhzwyYF8zYhCC9glIYuajVvqsGgMouJqCeB/GGBgjWGtrHIvw86alUPu 8nPuuGKDULOCkPq5BC7h+uDx16zM76XVoyRzMsIRY9aTrGLineq+/FMnXzE1xfGn7OP9 p0ZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g5si2647529pfj.302.2021.04.09.05.23.49; Fri, 09 Apr 2021 05:24:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231621AbhDIMXZ (ORCPT + 99 others); Fri, 9 Apr 2021 08:23:25 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:16865 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231127AbhDIMXZ (ORCPT ); Fri, 9 Apr 2021 08:23:25 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FGy091Yytz9xX2; Fri, 9 Apr 2021 20:20:57 +0800 (CST) Received: from DESKTOP-EFRLNPK.china.huawei.com (10.174.176.196) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.498.0; Fri, 9 Apr 2021 20:22:59 +0800 From: Qiheng Lin To: , , , , CC: , , , Qiheng Lin Subject: [PATCH -next] drm/etnaviv: remove unneeded if-null-free check Date: Fri, 9 Apr 2021 20:22:31 +0800 Message-ID: <20210409122231.8391-1-linqiheng@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Originating-IP: [10.174.176.196] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eliminate the following coccicheck warning: drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:616:2-8: WARNING: NULL check before some freeing functions is not needed. drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:618:2-8: WARNING: NULL check before some freeing functions is not needed. drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:620:2-8: WARNING: NULL check before some freeing functions is not needed. drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:622:2-8: WARNING: NULL check before some freeing functions is not needed. Signed-off-by: Qiheng Lin --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c index d05c35994579..bd0d66ebf314 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c @@ -612,14 +612,10 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data, err_submit_cmds: if (ret && (out_fence_fd >= 0)) put_unused_fd(out_fence_fd); - if (stream) - kvfree(stream); - if (bos) - kvfree(bos); - if (relocs) - kvfree(relocs); - if (pmrs) - kvfree(pmrs); + kvfree(stream); + kvfree(bos); + kvfree(relocs); + kvfree(pmrs); return ret; } -- 2.31.1