Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 9 Apr 2021 14:27:34 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc:     Clemens Gruber <clemens.gruber@pqgruber.com>,
        linux-pwm@vger.kernel.org, Sven Van Asbroeck <TheSven73@gmail.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v7 4/8] dt-bindings: pwm: Support new
 PWM_STAGGERING_ALLOWED flag
Message-ID: <YHBINhLa3pCZjoxO@orome.fritz.box>
References: <20210406164140.81423-1-clemens.gruber@pqgruber.com>
 <20210406164140.81423-4-clemens.gruber@pqgruber.com>
 <20210407053357.ok62rqpgyqou53m3@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="bALA5fzjI4YAv2cb"
Content-Disposition: inline
In-Reply-To: <20210407053357.ok62rqpgyqou53m3@pengutronix.de>
User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06)
Precedence: bulk


--bALA5fzjI4YAv2cb
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 07, 2021 at 07:33:57AM +0200, Uwe Kleine-K=C3=B6nig wrote:
> On Tue, Apr 06, 2021 at 06:41:36PM +0200, Clemens Gruber wrote:
> > Add the flag and corresponding documentation for the new PWM staggering
> > mode feature.
> >=20
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
>=20
> For the record, I don't like this and still prefer to make this
> staggering explicit for the consumer by expanding struct pwm_state with
> an .offset member to shift the active phase in the period.

How are consumers supposed to know which offset to choose? And worse:
how should consumers even know that the driver supports phase shifts?

Thierry

--bALA5fzjI4YAv2cb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmBwSDYACgkQ3SOs138+
s6HaHBAAqqXtYcIg6E5ADZv6/LDzrzvykS0Z6SBNDrh6QKpwkfHyhejv06aRtDm9
NZ49Flpuj5+hxTH15SKV9A0NRjpIs6e9L/8mq5pS6HhusKyKZelVUuTKEtH/aDI1
b53zcan3ooRkNfmKwJQnWvfoUIG/pXUXrXMYCkf2TYnQxafBLr6EeSqk3YGoU/GN
uLrYY6HOVe9zmz4pFfHSSAX8hHYW4FUsuqTeO2AOOH3eygICzNFhT/T0Wd9f6txY
QXWU9Wjw3GjEAxf/ispALrQuYacnjXtfKaQdN32RM0W1Z2sYf78A3tjqa9vaYXX1
RJasmE9z1gVLwN5eIk53xRBvMdUvtuEHwBHZK8mKtrSZ8zJ2GkGKLdZPtvHzcFPN
c4QmTZzKYhZ6VN91pWXI7wpKmC1lWF1uW7JVepYl5iw90U9E3bOhJPzQi77+ZGux
SJacNNwzRTfLx6KERgTGB1adIhEAxbUA3yiSN8ktVNrlx8ZN5EuLEhlU42Z2VoHc
5GGfCysKDah+mnnQElekv57+z2E2lyJZhqwbvliXlV0jYQmoddP1f7yt7vzBeymD
E1Tu2hFl/fz7ypF2+rxgm4aoMYm6a4y6Zli2FelvCE0J/UXY/FS3fxnHMLL3W8Po
buGPvntKEz7S5SrpHq1Pw2p5C16JRcgQYC1tAj162RjSVnhgFOY=
=ia/o
-----END PGP SIGNATURE-----

--bALA5fzjI4YAv2cb--