Date: Fri, 13 Oct 2006 02:39:26 +0200 (CEST)
From: Jiri Kosina <jikos@jikos.cz>
To: Russell King <rmk+lkml@arm.linux.org.uk>
cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix parport_serial_pci_resume() ignoring return value
 from pci_enable_device()
In-Reply-To: <20061012235820.GC24658@flint.arm.linux.org.uk>
Message-ID: <Pine.LNX.4.64.0610130229480.29022@twin.jikos.cz>
References: <Pine.LNX.4.64.0610130139510.29022@twin.jikos.cz>
 <20061012235820.GC24658@flint.arm.linux.org.uk>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 832
Lines: 23

On Fri, 13 Oct 2006, Russell King wrote:

> I suspect all these kind of patches are introducing additional problems.
> This one certainly is.  Who's auditing all these patches?  I mean _properly_
> auditing them rather than just saying "that's a good idea"?

For the fm801 gameport case it is fine - it's just one more check in the 
_probe() function, performing the same error path as other cases do.

ALSA case has already been solved by calling snd_card_disconnect() on 
error path.

But I agree that sk98lin and parport_serial_pci patches are likely broken.

Thanks,

-- 
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/