Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210408130605.541796-1-gi-oh.kim@ionos.com> <20210408220502.8126bc2f278b5199707ec122@linux-foundation.org>
 <CAHp75VcjNWycV-SLUzzfgtMp8BzXUiUAoz_BYr4+nCazAzsrqw@mail.gmail.com>
In-Reply-To: <CAHp75VcjNWycV-SLUzzfgtMp8BzXUiUAoz_BYr4+nCazAzsrqw@mail.gmail.com>
From:   Gioh Kim <gi-oh.kim@ionos.com>
Date:   Fri, 9 Apr 2021 14:41:04 +0200
Message-ID: <CAJX1YtZtXoLmbwvAk40CHZ0_LtE__+SvvyWYYvcJaHAeDH4Chg@mail.gmail.com>
Subject: Re: [PATCH v4] lib/string: Introduce sysfs_streqcase
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ndesaulniers@google.com" <ndesaulniers@google.com>,
        "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
        "laniel_francis@privacyrequired.com" 
        <laniel_francis@privacyrequired.com>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "dja@axtens.net" <dja@axtens.net>,
        "haris.iqbal@ionos.com" <haris.iqbal@ionos.com>,
        "jinpu.wang@ionos.com" <jinpu.wang@ionos.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Apr 9, 2021 at 9:11 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
>
>
> On Friday, April 9, 2021, Andrew Morton <akpm@linux-foundation.org> wrote=
:
>>
>> On Thu,  8 Apr 2021 15:06:05 +0200 Gioh Kim <gi-oh.kim@ionos.com> wrote:
>>
>> > As the name shows, it checks if strings are equal in case insensitive
>> > manner.
>>
>> Peh.  Who would die if we simply made sysfs_streq() case-insensitive?
>
>
> I think it will be a disaster. Like we have with case-insensitive file sy=
stems. Famous Mac case that most of the soft stop working when they actuall=
y moved to the right direction, I.e. case-sensitive. Personally I=E2=80=99m=
 against such change.

Hi Andy,

I am sorry but I am a little bit confused because I don't have any
experience with case-insensitive file systems.
I think the case-insensitive file system does not care if sysfs_streq
is changed to case-insensitive.

For example, if the case-insensitive file system would accept the "OFF" com=
mand,
the user can pass either of "off" and "OFF" and both will work with
case-insensitive strfs_streq.

On the contrary, I think the case-sensitive file system would not like
it if sysfs_streq is made case-insensitive.

Could you please inform me what I am missing?

>
>
>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>