Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 9 Apr 2021 15:03:20 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Clemens Gruber <clemens.gruber@pqgruber.com>
Cc:     linux-pwm@vger.kernel.org, Sven Van Asbroeck <TheSven73@gmail.com>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 3/8] pwm: pca9685: Improve runtime PM behavior
Message-ID: <YHBQmGJIsa6sNRIg@orome.fritz.box>
References: <20210406164140.81423-1-clemens.gruber@pqgruber.com>
 <20210406164140.81423-3-clemens.gruber@pqgruber.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="yucEIjxemkfSPh6I"
Content-Disposition: inline
In-Reply-To: <20210406164140.81423-3-clemens.gruber@pqgruber.com>
User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06)
Precedence: bulk


--yucEIjxemkfSPh6I
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 06, 2021 at 06:41:35PM +0200, Clemens Gruber wrote:
> The chip does not come out of POR in active state but in sleep state.
> To be sure (in case the bootloader woke it up) we force it to sleep in
> probe.
>=20
> On kernels without CONFIG_PM, we wake the chip in .probe and put it to
> sleep in .remove.
>=20
> Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> ---
> Changes since v6:
> - Improved !CONFIG_PM handling (wake it up without putting it to sleep
>   first)
>=20
>  drivers/pwm/pwm-pca9685.c | 26 +++++++++++++++++++-------
>  1 file changed, 19 insertions(+), 7 deletions(-)
>=20
> diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c
> index d4474c5ff96f..0bcec04b138a 100644
> --- a/drivers/pwm/pwm-pca9685.c
> +++ b/drivers/pwm/pwm-pca9685.c
> @@ -474,13 +474,18 @@ static int pca9685_pwm_probe(struct i2c_client *cli=
ent,
>  		return ret;
>  	}
> =20
> -	/* The chip comes out of power-up in the active state */
> -	pm_runtime_set_active(&client->dev);
> -	/*
> -	 * Enable will put the chip into suspend, which is what we
> -	 * want as all outputs are disabled at this point
> -	 */
> -	pm_runtime_enable(&client->dev);
> +	if (IS_ENABLED(CONFIG_PM)) {

This looks odd to me. I've seen similar constructs, but they usually go
something like this (I think):

	pm_runtime_enable(&client->dev);

	if (!pm_runtime_enabled(&client->dev)) {
		/* resume device */
	}

Which I guess in your would be somewhat the opposite and it wouldn't
actually resume the device but rather put it to sleep.

Perhaps something like this:

	pm_runtime_enable(&client->dev);

	if (pm_runtime_enabled(&client->dev)) {
		pca9685_set_sleep_mode(pca, true);
		pm_runtime_set_suspended(&client->dev);
	} else {
		/* wake the chip up on non-PM environments */
		pca9685_set_sleep_mode(pca, false);
	}

? I think that's slightly more correct than your original because it
takes into account things like sysfs power control and such. It also
doesn't rely on the config option alone but instead uses the runtime
PM API to achieve this more transparently.

Thierry

--yucEIjxemkfSPh6I
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmBwUJYACgkQ3SOs138+
s6Er7RAAjikTXssRSRsCCvtNEO0zM04tAdA7IVWeR1W3tbQsey1b6G9xqZL6hHoC
gDt8wdLMh4/BvkseBGRWzyBkI0oN9Vry/pxZQg+izgmjpb5TTN6iVDmW7+fMumLP
aQwogG14Gu3dinGWHIIndKSI/swpRSzq8jlV8CC0liuqzdEG28mQRz81uNANBDfA
Llo9sRBPmuDIxHdR1dyOmacyMFxmrwZy79GgObDwEmDZGEGzdTMrVnPYpHUhRa16
+DdATITfzlLBDqcjbaCDiK38xsSiAYxQW+WykxjpIetHAxEAt1zZmgCTjcQ53+CT
8oFi1fWIky+dyG+shDYnVXr+58nyOoLNweTxH499cETgaL+69CYoOceF+C5ePGQv
u/CKWCrY1tDppHKcOV1oNk9b91uH8+H6Dy+R5HKZltzduh5dTt5v0WBHIrmmtm9k
fgY8vs8yp0uQ/AqKiSj4Y8cCoGOUYNxoiVQDkpkcEP3JLRGs+r6bzqAdMK4wWbCL
YnqfrjgTNVIJjdadNBFEBw+xEa0eraPrLn/aYvbYUTWbUhYleJg5IMblXwHsQ5F4
MXPunIu195VL7a77zRJqovTYNviMu4nsRKluktv+FAAjLujyeIxl3Pm8odzvhmga
QIryBk5yj0gcwHLkSMKsaAj1VAM7Ob15B3QUQ2M4vyfBi1fm2LY=
=k4Q5
-----END PGP SIGNATURE-----

--yucEIjxemkfSPh6I--