Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 9 Apr 2021 16:14:04 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     dev.dragon@bk.ru
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8192u: ieee80211: fixed a trailing
 statements coding style issue.
Message-ID: <20210409131403.GB6021@kadam>
References: <20210404051500.6644-1-dev.dragon@bk.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210404051500.6644-1-dev.dragon@bk.ru>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Sun, Apr 04, 2021 at 08:15:00AM +0300, dev.dragon@bk.ru wrote:
> From: Dmitrii Wolf <dev.dragon@bk.ru>
> 
> Signed-off-by: Dmitrii Wolf <dev.dragon@bk.ru>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> index 690b664df8fa..29a6ce20e2bd 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> @@ -2048,12 +2048,12 @@ void ieee80211_softmac_xmit(struct ieee80211_txb *txb, struct ieee80211_device *
>  	/* if xmit available, just xmit it immediately, else just insert it to the wait queue */
>  	for (i = 0; i < txb->nr_frags; i++) {
>  #ifdef USB_TX_DRIVER_AGGREGATION_ENABLE
> -		if ((skb_queue_len(&ieee->skb_drv_aggQ[queue_index]) != 0) ||
> +		if ((skb_queue_len(&ieee->skb_drv_aggQ[queue_index]) != 0)
>  #else
> -		if ((skb_queue_len(&ieee->skb_waitQ[queue_index]) != 0) ||
> +		if ((skb_queue_len(&ieee->skb_waitQ[queue_index]) != 0)
>  #endif
> -		    (!ieee->check_nic_enough_desc(ieee->dev, queue_index)) || \
> -		    (ieee->queue_stop)) {
> +		 || (!ieee->check_nic_enough_desc(ieee->dev, queue_index)) \
> +		 || (ieee->queue_stop)) {

No.  The || go on the end, the way the original code had it.  I've no
idea what you were trying to fix.  Maybe the \ characters?

regards,
dan carpenter