Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 9 Apr 2021 15:49:08 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Jin Yao <yao.jin@linux.intel.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v3 10/27] perf parse-events: Create two hybrid raw events
Message-ID: <YHBbVMNSCsu/bbii@krava>
References: <20210329070046.8815-1-yao.jin@linux.intel.com>
 <20210329070046.8815-11-yao.jin@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210329070046.8815-11-yao.jin@linux.intel.com>
Precedence: bulk

On Mon, Mar 29, 2021 at 03:00:29PM +0800, Jin Yao wrote:

SNIP

> +					      name, config_terms, pmu);
> +		if (ret)
> +			return ret;
> +	}
> +
> +	return 0;
> +}
> +
>  int parse_events__add_numeric_hybrid(struct parse_events_state *parse_state,
>  				     struct list_head *list,
>  				     struct perf_event_attr *attr,
> @@ -91,6 +126,9 @@ int parse_events__add_numeric_hybrid(struct parse_events_state *parse_state,
>  	if (attr->type != PERF_TYPE_RAW) {
>  		return add_hw_hybrid(parse_state, list, attr, name,
>  				     config_terms);
> +	} else {
> +		return add_raw_hybrid(parse_state, list, attr, name,
> +				      config_terms);
>  	}
>  
>  	return -1;

no need for the return -1

jirka

> -- 
> 2.17.1
>