Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 9 Apr 2021 16:59:40 +0300
From:   Mike Rapoport <rppt@linux.ibm.com>
To:     David Hildenbrand <david@redhat.com>
Cc:     Alex Ghiti <alex@ghiti.fr>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arch@vger.kernel.org, linux-mm@kvack.org,
        Vitaly Wool <vitaly.wool@konsulko.com>
Subject: Re: [PATCH v7] RISC-V: enable XIP
Message-ID: <YHBdzPsHantT9r8t@linux.ibm.com>
References: <20210409065115.11054-1-alex@ghiti.fr>
 <3500f3cb-b660-5bbc-ae8d-0c9770e4a573@ghiti.fr>
 <be575094-badf-bac7-1629-36808ca530cc@redhat.com>
 <c4e78916-7e4c-76db-47f6-4dda3f09c871@ghiti.fr>
 <YHBEsDuEvPAnL8Vb@linux.ibm.com>
 <e7e87306-bb04-2d4f-7e7f-aabd40dccb3b@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e7e87306-bb04-2d4f-7e7f-aabd40dccb3b@redhat.com>
Precedence: bulk

On Fri, Apr 09, 2021 at 02:46:17PM +0200, David Hildenbrand wrote:
> > > > Also, will that memory properly be exposed in the resource tree as
> > > > System RAM (e.g., /proc/iomem) ? Otherwise some things (/proc/kcore)
> > > > won't work as expected - the kernel won't be included in a dump.
> > Do we really need a XIP kernel to included in kdump?
> > And does not it sound weird to expose flash as System RAM in /proc/iomem? ;-)
> 
> See my other mail, maybe we actually want something different.
> 
> > 
> > > I have just checked and it does not appear in /proc/iomem.
> > > 
> > > Ok your conclusion would be to have struct page, I'm going to implement this
> > > version then using memblock as you described.
> > 
> > I'm not sure this is required. With XIP kernel text never gets into RAM, so
> > it does not seem to require struct page.
> > 
> > XIP by definition has some limitations relatively to "normal" operation,
> > so lack of kdump could be one of them.
> 
> I agree.
> 
> > 
> > I might be wrong, but IMHO, artificially creating a memory map for part of
> > flash would cause more problems in the long run.
> 
> Can you elaborate?

Nothing particular, just a gut feeling. Usually, when you force something
it comes out the wrong way later.
 
> > 
> > BTW, how does XIP account the kernel text on other architectures that
> > implement it?
> 
> Interesting point, I thought XIP would be something new on RISC-V (well, at
> least to me :) ). If that concept exists already, we better mimic what
> existing implementations do.

I had quick glance at ARM, it seems that kernel text does not have memory
map and does not show up in System RAM.

-- 
Sincerely yours,
Mike.