Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Qiheng Lin <linqiheng@huawei.com>
CC:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Martin Petersen <martin.petersen@oracle.com>,
        Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] scsi: qla2xxx: remove unneeded if-null-free check
Thread-Topic: [PATCH -next] scsi: qla2xxx: remove unneeded if-null-free check
Thread-Index: AQHXLTlBwWVQCI/QakK/1FfnyX1QRKqsO0EA
Date:   Fri, 9 Apr 2021 14:15:55 +0000
Message-ID: <A67C5FAE-D566-4704-8A82-216CAC369E2D@oracle.com>
References: <20210409120925.7122-1-linqiheng@huawei.com>
In-Reply-To: <20210409120925.7122-1-linqiheng@huawei.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CC535D355BF2BC43A89717F4BC49A3C5@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 081cf3d0-f7f4-4e7f-8893-08d8fb61fd8e
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2021 14:15:55.6271
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ejVq+g8TmVU5JtPSjk76etF+a+vh0ZbvQCScQOab2ReD3BGUU4A75+mdjh7hmaJeFPgQ3TDjJiwkNoE1zaETWRzM6HCaITnEXLHWpFItQvA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2912
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9949 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999
 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104060000 definitions=main-2104090106
X-Proofpoint-ORIG-GUID: Huj77QtTUe2VUtdPni5jXcwTvjpPwWWc
X-Proofpoint-GUID: Huj77QtTUe2VUtdPni5jXcwTvjpPwWWc
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9949 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 priorityscore=1501
 suspectscore=0 phishscore=0 mlxlogscore=999 spamscore=0 malwarescore=0
 mlxscore=0 bulkscore=0 impostorscore=0 adultscore=0 clxscore=1011
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000
 definitions=main-2104090107
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Apr 9, 2021, at 7:09 AM, Qiheng Lin <linqiheng@huawei.com> wrote:
>=20
> Eliminate the following coccicheck warning:
>=20
> drivers/scsi/qla2xxx/qla_os.c:4622:2-7:
> WARNING: NULL check before some freeing functions is not needed.
> drivers/scsi/qla2xxx/qla_os.c:4637:3-8:
> WARNING: NULL check before some freeing functions is not needed.
>=20
> Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.=
c
> index 12959e3874cb..d74c32f84ef5 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -4618,8 +4618,7 @@ qla2x00_free_fw_dump(struct qla_hw_data *ha)
> 		dma_free_coherent(&ha->pdev->dev,
> 		    EFT_SIZE, ha->eft, ha->eft_dma);
>=20
> -	if (ha->fw_dump)
> -		vfree(ha->fw_dump);
> +	vfree(ha->fw_dump);
>=20
> 	ha->fce =3D NULL;
> 	ha->fce_dma =3D 0;
> @@ -4633,8 +4632,7 @@ qla2x00_free_fw_dump(struct qla_hw_data *ha)
> 	ha->fw_dump_len =3D 0;
>=20
> 	for (j =3D 0; j < 2; j++, fwdt++) {
> -		if (fwdt->template)
> -			vfree(fwdt->template);
> +		vfree(fwdt->template);
> 		fwdt->template =3D NULL;
> 		fwdt->length =3D 0;
> 	}
> --=20
> 2.31.1
>=20

Looks Good.=20

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering