Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: bc3yPWVyjWhkT6GfB1XhFLvZSIj70qUok42XmoAca9XvDmade0mLtP/SuI99x8fTigf6Y/OtsM
 fQKhZAYMAR8g==
IronPort-SDR: VaQNFTTlcncnSAeVCU4i7GQ4isH2oSsQWCJ8+4m2g35L4aaY6wP5VRPb3AEEXzkj49/rHGB66D
 F0UWNVjupBwA==
Subject: Re: [PATCH] ASoC: Intel: bytcr_wm5102: remove useless variable
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        cezary.rojewski@intel.com
Cc:     liam.r.girdwood@linux.intel.com, yang.jie@linux.intel.com,
        broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
References: <1617948506-84638-1-git-send-email-jiapeng.chong@linux.alibaba.com>
From:   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Message-ID: <ec10b000-34da-b4e8-8fa4-abb366557646@linux.intel.com>
Date:   Fri, 9 Apr 2021 10:37:29 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <1617948506-84638-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 4/9/21 1:08 AM, Jiapeng Chong wrote:
> Fix the following gcc warning:
> 
> sound/soc/intel/boards/bytcr_wm5102.c:216:40: warning:
> ‘byt_wm5102_dai_params’ defined but not used.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Thanks for the patch.

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> ---
>   sound/soc/intel/boards/bytcr_wm5102.c | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/sound/soc/intel/boards/bytcr_wm5102.c b/sound/soc/intel/boards/bytcr_wm5102.c
> index f38850e..fd584e3 100644
> --- a/sound/soc/intel/boards/bytcr_wm5102.c
> +++ b/sound/soc/intel/boards/bytcr_wm5102.c
> @@ -213,14 +213,6 @@ static int byt_wm5102_init(struct snd_soc_pcm_runtime *runtime)
>   	return 0;
>   }
>   
> -static const struct snd_soc_pcm_stream byt_wm5102_dai_params = {
> -	.formats = SNDRV_PCM_FMTBIT_S16_LE,
> -	.rate_min = 48000,
> -	.rate_max = 48000,
> -	.channels_min = 2,
> -	.channels_max = 2,
> -};
> -
>   static int byt_wm5102_codec_fixup(struct snd_soc_pcm_runtime *rtd,
>   				  struct snd_pcm_hw_params *params)
>   {
>