Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than
 zero
From:   Sergei Shtylyov <sergei.shtylyov@gmail.com>
To:     angkery <angkery@163.com>, axboe@kernel.dk
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
        Junlin Yang <yangjunlin@yulong.com>
References: <20210409135426.1773-1-angkery@163.com>
 <e74ec570-96b6-23ce-edd5-b5a38628963a@gmail.com>
Message-ID: <e6bf7f02-f0b8-b0c4-2253-62a55ea98d17@gmail.com>
Date:   Fri, 9 Apr 2021 20:02:56 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <e74ec570-96b6-23ce-edd5-b5a38628963a@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/9/21 7:49 PM, Sergei Shtylyov wrote:

>> From: Junlin Yang <yangjunlin@yulong.com>
>>
>> The return from the call to platform_get_irq() is int, it can be
>> a negative error code, however this is being assigned to an unsigned
>> int variable 'irq', so making 'irq' an int, and change the position to
>> keep the code format.
>>
>> ./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
>> WARNING: Unsigned expression compared with zero: irq > 0
> 
>    I'd understand < 0... but > 0? What tool warned about this issue?
> 
>> Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
>> ---
>>  drivers/ata/pata_ixp4xx_cf.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
>> index abc0e87..43215a4 100644
>> --- a/drivers/ata/pata_ixp4xx_cf.c
>> +++ b/drivers/ata/pata_ixp4xx_cf.c
>> @@ -135,12 +135,12 @@ static void ixp4xx_setup_port(struct ata_port *ap,
>>  
>>  static int ixp4xx_pata_probe(struct platform_device *pdev)
>>  {
>> -	unsigned int irq;
> 
>    Oops, not sure how I missed that. :-/
>    Thanks for fixing my overlook. :-)

   Forgot to add my

Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>

> [...]

MBR, Sergei