Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751253AbWJMHaS (ORCPT ); Fri, 13 Oct 2006 03:30:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751262AbWJMHaS (ORCPT ); Fri, 13 Oct 2006 03:30:18 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:32466 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1751253AbWJMHaR (ORCPT ); Fri, 13 Oct 2006 03:30:17 -0400 Date: Fri, 13 Oct 2006 08:30:10 +0100 From: Christoph Hellwig To: Casey Dahlin Cc: Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Readability improvement of open_exec() Message-ID: <20061013073010.GB13531@infradead.org> Mail-Followup-To: Christoph Hellwig , Casey Dahlin , Linus Torvalds , linux-kernel@vger.kernel.org References: <1160707333.3230.14.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1160707333.3230.14.camel@localhost.localdomain> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 531 Lines: 16 > + if (err) > + goto out; > + > + inode = nd.dentry->d_inode; > + file = ERR_PTR(-EACCES); > + if ((nd.mnt->mnt_flags & MNT_NOEXEC) || > + !S_ISREG(inode->i_mode)) While you're cleaning up things you can put the whole if statement on one line, it's less than 80 characters long. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/