Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Christian Eggers <ceggers@arri.de>
To:     <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Jiri Prchal <jiri.prchal@aksignal.cz>
CC:     Rob Herring <robh+dt@kernel.org>,
        Jiri Prchal <jiri.prchal@aksignal.cz>
Subject: Re: [PATCH 0/3] nvmem: eeprom: add support for FRAM
Date:   Fri, 9 Apr 2021 19:21:47 +0200
Message-ID: <4311739.LvFx2qVVIh@n95hx1g2>
Organization: Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
In-Reply-To: <20210409154720.130902-1-jiri.prchal@aksignal.cz>
References: <20210409154720.130902-1-jiri.prchal@aksignal.cz>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Hi Jiri,

I have two Fujitsu different FRAMs running with the stock at25 driver. I set
the page size equal to the device size (as FRAMs have no pages).  

Are you able to run your FRAM with the unmodified driver?

I assume that getting the device geometry from the chip is vendor specific (in
contrast to flash devices which have standard commands for this).  I suppose
that there is no much value getting vendor specific information from a chip. If
the drivers knows the vendor, it should also know the chip (e.g. from the dt).

regards
Christian

On Friday, 9 April 2021, 17:47:17 CEST, Jiri Prchal wrote:
> Adds sopport for Cypress FRAMs.
> 
> Jiri Prchal (3):
>   nvmem: eeprom: at25: add support for FRAM
>   nvmem: eeprom: at25: add support for FRAM
>   nvmem: eeprom: add documentation for FRAM
> 
>  .../devicetree/bindings/eeprom/at25.yaml      |  12 +-
>  drivers/misc/eeprom/Kconfig                   |   5 +-
>  drivers/misc/eeprom/at25.c                    | 151 ++++++++++++++----
>  drivers/nvmem/core.c                          |   4 +
>  include/linux/nvmem-provider.h                |   1 +
>  5 files changed, 139 insertions(+), 34 deletions(-)
> 
>