Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1567836pxf; Fri, 9 Apr 2021 11:34:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1pG+r5Ijs7IfOB4gIJJrTxV1Fzw4kG+RVzCvWt+mbf3NafqM2D7qU1oskHED0+thwXthe X-Received: by 2002:a63:dc49:: with SMTP id f9mr14436045pgj.361.1617993271561; Fri, 09 Apr 2021 11:34:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617993271; cv=none; d=google.com; s=arc-20160816; b=a1UxnlGmMl7g0NBTTX+wvXJwM4OEATjGb8wo995NbO/knQy8vvenbtXVJ4/aB8LIOJ GyJ2Vae2huZUGtrpYMAYA/BvV4Ri75398VseLhdH0cNfPSQQlhYav9NtBG7DTj3kzcgt b4wmTjz5NUPi/4/6MkHto2NlKRLhnmtAFT86rI0NJob05XwBZdcv4VYDCpDIwM32D2gt NKqlMraudZpGHCIUcjiCjSWu79X7o4XUaeMkyXKzGhMY/P131ps2WH4kdhjNwuLgM4j5 lGNOLP1HvetG099Uxl13DFbX/mfTperODcXGBVltf99+TCFLsmbERjFpu3aFFIqgSiDG dMqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=saDw2irPVKnwGeLPBL5IVZRbilJg+scGi3r1CfJCJow=; b=JbLGoDHn9mXCta7mnsi1d2gGRpKXVAuiXyPLdT7PDNKkv1vlAmru7zLHhUOxnfh3XC lXVvh21yi2zsaPE7OIYIOOVerXzocuQbOeKEldExL751EGmAGWkeVuXFGTBxJPjZf/Rg m5lxk/KX+ulsiA3FszXvafK7lOeN889ad/WT6b5X3vUzVIE90KyIT3IaO/YRucjrTiOS eAxQskQVVhGc/suOWcjTUuzDLedvCb+zkMYu3HzOfGWwn9fl/5Ei7GGilcQJAsR7Mdqn PZwHFzUl3dh+pWRXn/fyO0SfLCT8ghxFcWPY9KgZ9TjR86FutMxyj0SEUPiow8qlS1KL k94g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OXmDr1aX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 62si3612595ple.18.2021.04.09.11.34.19; Fri, 09 Apr 2021 11:34:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OXmDr1aX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234418AbhDISdU (ORCPT + 99 others); Fri, 9 Apr 2021 14:33:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234307AbhDISdR (ORCPT ); Fri, 9 Apr 2021 14:33:17 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09062C061762; Fri, 9 Apr 2021 11:33:03 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id j5so5561535wrn.4; Fri, 09 Apr 2021 11:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=saDw2irPVKnwGeLPBL5IVZRbilJg+scGi3r1CfJCJow=; b=OXmDr1aXvJf/a3kz7C38TwfICyHvUxlX9axM/LerixBCFTRUCDaVNVmBwD+T9CGAho aOLKckeM+0ySveicmcSUMX9jabp2y89piHr6MSe0dblaUFNHbrVnwvI5SLzJBXl3TmVN 3k59Kn04BvidBp25wrRXVmdSoTdqR1Z3vEesQg1mlEWL57fu8USN3c9pYek15o9sBEMG y1XozjnVLE0JCHVlugL29CpPLDJkAqhtNn69bwCEx8dSBHgWtKfQdaZvU4L2qVO68n9M H7gnkQGOyD0+G/KxPXUCqlAQHvUNnLyCgOzyd5OW23TJIQAuHMEy9T/CkheWcbrVq+A3 N0PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=saDw2irPVKnwGeLPBL5IVZRbilJg+scGi3r1CfJCJow=; b=JR4r/fAJiQ/M7NWwlJjN0BWz1NDvej1Z2dp1Ao2cSoSRiruEzeT/UzvHk+rMAzEBTa EpiVilNQkb130V27vHcoHXZeG+zdyIdtMvxVdN8i7HJB2PDMTyoNMhHAPveZDdY7VMVY FQeMI9MxMQdEmxvQAk+/x8OBdT4SIZXe3aQzU2iGWjd6qs+z+J4bgqKrPYfSH7Kf+1/F UKAC3o3HlFDrwQhYioytWd48UvQ9criF0vJ/ta3DHst4R75PhGIF+vH1s4dnulLSAZif sp5fZddJukjd7nWbK5gCqVN6uQBNDqqV2Qt2Kggp6hLXfp5fzv7Pzx6JhaRtMBN0LyeW hHgw== X-Gm-Message-State: AOAM530A8/x17yjWTRIyThiIyOcVjbgFtEPMp+5Kb36krpAn+sLxkdxh Cls4kArd5O5LlBtaWASZs0U= X-Received: by 2002:adf:c452:: with SMTP id a18mr18461159wrg.378.1617993181858; Fri, 09 Apr 2021 11:33:01 -0700 (PDT) Received: from LEGION ([39.46.65.172]) by smtp.gmail.com with ESMTPSA id v7sm5152025wme.47.2021.04.09.11.32.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 11:33:01 -0700 (PDT) Date: Fri, 9 Apr 2021 23:32:54 +0500 From: Muhammad Usama Anjum To: Alexander Viro , Jens Axboe , "open list:FILESYSTEMS (VFS and infrastructure)" , "open list:BLOCK LAYER" , open list , hch@lst.de Cc: musamaanjum@gmail.com, kernel-janitors@vger.kernel.org, dan.carpenter@oracle.com Subject: [PATCH] block: initialize variable ret with 0 Message-ID: <20210409183254.GA3534403@LEGION> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ret variable is not being set if get_capacity returns 0 in very first try. It should be initialized with 0 for this case. Addresses-Coverity: ("Uninitialized variable") Fixes: d3c4a43d92 ("block: refactor blk_drop_partitions") Signed-off-by: Muhammad Usama Anjum --- fs/block_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/block_dev.c b/fs/block_dev.c index bb02b4be7f1c..986951bfee85 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -1240,7 +1240,7 @@ static void __blkdev_put(struct block_device *bdev, fmode_t mode, int for_part); int bdev_disk_changed(struct block_device *bdev, bool invalidate) { struct gendisk *disk = bdev->bd_disk; - int ret; + int ret = 0; lockdep_assert_held(&bdev->bd_mutex); -- 2.25.1