Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750811AbWJMIAG (ORCPT ); Fri, 13 Oct 2006 04:00:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750881AbWJMIAF (ORCPT ); Fri, 13 Oct 2006 04:00:05 -0400 Received: from caramon.arm.linux.org.uk ([217.147.92.249]:3337 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S1750811AbWJMIAA (ORCPT ); Fri, 13 Oct 2006 04:00:00 -0400 Date: Fri, 13 Oct 2006 08:59:53 +0100 From: Russell King To: Jeff Garzik Cc: linux-serial@vger.kernel.org, Andrew Morton , LKML Subject: Re: [PATCH] serial: handle pci_enable_device() failure upon resume Message-ID: <20061013075953.GC28654@flint.arm.linux.org.uk> Mail-Followup-To: Jeff Garzik , linux-serial@vger.kernel.org, Andrew Morton , LKML References: <20061012014720.GA12935@havoc.gtf.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061012014720.GA12935@havoc.gtf.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 864 Lines: 22 On Wed, Oct 11, 2006 at 09:47:20PM -0400, Jeff Garzik wrote: > Signed-off-by: Jeff Garzik NAK. What happens to the ports if pci_enable_device() fails and someone has them open? It's far better to leave the must_check warning behind until it can be _correctly_ solved, rather than papering over the problem with bogus patches to return errors without taking an appropriate additional action. IOW, the warnings serve as a reminder that *proper* error handling needs to be implemented. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/