Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 9 Apr 2021 23:34:43 +0300
From:   Ilias Apalodimas <ilias.apalodimas@linaro.org>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Matteo Croce <mcroce@linux.microsoft.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Saeed Mahameed <saeedm@nvidia.com>,
        David Ahern <dsahern@gmail.com>,
        Saeed Mahameed <saeed@kernel.org>, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB
 recycling
Message-ID: <YHC6Y0jSte0fWygK@apalos.home>
References: <20210402181733.32250-1-mcroce@linux.microsoft.com>
 <20210402181733.32250-4-mcroce@linux.microsoft.com>
 <20210409115648.169523fd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <YHCknwlzJHPFXm2j@apalos.home>
 <20210409122929.5c2793df@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210409122929.5c2793df@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Precedence: bulk

On Fri, Apr 09, 2021 at 12:29:29PM -0700, Jakub Kicinski wrote:
> On Fri, 9 Apr 2021 22:01:51 +0300 Ilias Apalodimas wrote:
> > On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote:
> > > On Fri,  2 Apr 2021 20:17:31 +0200 Matteo Croce wrote:  
> > > > Co-developed-by: Jesper Dangaard Brouer <brouer@redhat.com>
> > > > Co-developed-by: Matteo Croce <mcroce@microsoft.com>
> > > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>  
> > > 
> > > Checkpatch says we need sign-offs from all authors.
> > > Especially you since you're posting.  
> > 
> > Yes it does, we forgot that.  Let me take a chance on this one. 
> > The patch is changing the default skb return path and while we've done enough
> > testing, I would really prefer this going in on a future -rc1 (assuming we even
> > consider merging it), allowing enough time to have wider tests.
> 
> Up to you guys. FWIW if you decide to try for 5.13 the missing signoffs
> can be posted in replies, no need to repost.
Thanks! but...
I think I prefer another repost, including mm-people on the list as well (and
fixing SoB's).
I just noticed noone is cc'ed and patch [2/5] adds a line in mm_types.h

/Ilias