Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210409082522.625168-1-tudor.ambarus@microchip.com>
In-Reply-To: <20210409082522.625168-1-tudor.ambarus@microchip.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Sat, 10 Apr 2021 02:08:39 +0200
Message-ID: <CACRpkdbRfnZT9OU3FccZ7vny+Ami=k+dkDr4Lo7w_JOgzotX9A@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: at91-pio4: Fix slew rate disablement
To:     Tudor Ambarus <tudor.ambarus@microchip.com>
Cc:     Ludovic Desroches <ludovic.desroches@microchip.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Apr 9, 2021 at 10:25 AM Tudor Ambarus
<tudor.ambarus@microchip.com> wrote:

> The slew rate was enabled by default for each configuration of the
> pin. In case the pin had more than one configuration, even if
> we set the slew rate as disabled in the device tree, the next pin
> configuration would set again the slew rate enabled by default,
> overwriting the slew rate disablement.
> Instead of enabling the slew rate by default for each pin configuration,
> enable the slew rate by default just once per pin, regardless of the
> number of configurations. This way the slew rate disablement will also
> work for cases where pins have multiple configurations.
>
> Fixes: 440b144978ba ("pinctrl: at91-pio4: add support for slew-rate")
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Patch applied!

Yours,
Linus Walleij