Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp203857pxb; Fri, 9 Apr 2021 23:48:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1ZrWumHnL/WRxkLW7FFbTfAVfoFwyYpNlqV22IlOu0Esz/gXO4aFYTzdpjUAaiDoc0WjD X-Received: by 2002:a63:e242:: with SMTP id y2mr17275805pgj.298.1618037329558; Fri, 09 Apr 2021 23:48:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618037329; cv=none; d=google.com; s=arc-20160816; b=0IG053Td6odtLXkntANDmbYr+MvM2BrUX9TE/PPGFMt9A8o/UcoKkY/RHOTGVuc/Vy 06TMzM0NQUoKp/nL7iyj+PcieUMDvbig0JECnU/a+HPb0gmudIcvqOaQmWnPTbTBnX7i fxXnCM/Do/xRlLx3kyWy6bv7ZNFwDh0GHK3ANh7pTk6IePft8+i6ByhlYGXvnwaCD3cA Mk9LcEhkUQXWeA+GE6YM8ZaK6Jbi2ViQNv2e3TnHh09hC0HE4kAsrd5kTLdJMR6clv/h AYwkeEEKoKAedNAb7bQDziVlU6gxqtVAXlo0s390zN4om7qAp1qBw/LBjSbj+0Q7wbzz P8cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=a555aa2V0heZUm0J38Mkz5DoCkJ8KEsBlWCWp+86Vz4=; b=GM62Aw7wWkcG/OpxU9ouFDI7oJbwYw1YA1fbVOV8ysJVmkBvGncEEqqitJgICNinXy G1nqQ5MxXmFtycz4okEkS0YtJJzSOj/8seSqWKo0jtEXJAJhKgbiGOF5ew76VI4K2QXR znCQXqH0LJgdwlbemYg+Wb8xSdNbznJrB71go8WnjNw5jC07VA4oj71zQ0i8RN4jsk2m e+nZ2XT2QCP2QhBcnHteD7eKQq6TN/pREWCTCUo0xuiLRvQkGMbKs92lbXOqSVN01+Ac vsLMJqmTx13ZwhZ4oeiUTWV+VJ7+NTq/QDWPyweLEj8EPnfh8sboCvrTWenSA6tSIA8V fppA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m6si5563283pfd.292.2021.04.09.23.48.36; Fri, 09 Apr 2021 23:48:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234393AbhDJGsM (ORCPT + 99 others); Sat, 10 Apr 2021 02:48:12 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:16883 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233527AbhDJGsJ (ORCPT ); Sat, 10 Apr 2021 02:48:09 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FHQWJ5KSGzkhsB; Sat, 10 Apr 2021 14:46:04 +0800 (CST) Received: from huawei.com (10.69.192.56) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Sat, 10 Apr 2021 14:47:45 +0800 From: Luo Jiaxing To: , , , , CC: , , , , Subject: [PATCH v1 5/8] scsi: megaraid: clean up for "foo * bar" Date: Sat, 10 Apr 2021 14:48:04 +0800 Message-ID: <1618037287-460-6-git-send-email-luojiaxing@huawei.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1618037287-460-1-git-send-email-luojiaxing@huawei.com> References: <1618037287-460-1-git-send-email-luojiaxing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Following error is reported by checkpatch.pl: "foo * bar" should be "foo *bar" + struct megasas_iocpacket __user * user_ioc, The format of the pointer variable must be "foo *bar", so fix them. Signed-off-by: Luo Jiaxing --- drivers/scsi/megaraid/megaraid_ioctl.h | 4 ++-- drivers/scsi/megaraid/megaraid_mbox.h | 2 +- drivers/scsi/megaraid/megaraid_mm.c | 4 ++-- drivers/scsi/megaraid/megaraid_sas_base.c | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_ioctl.h b/drivers/scsi/megaraid/megaraid_ioctl.h index 87b880fe..9bc0250 100644 --- a/drivers/scsi/megaraid/megaraid_ioctl.h +++ b/drivers/scsi/megaraid/megaraid_ioctl.h @@ -126,7 +126,7 @@ typedef struct uioc { uint8_t reserved[128]; /* Driver Data: */ - void __user * user_data; + void __user *user_data; uint32_t user_data_len; /* 64bit alignment */ @@ -138,7 +138,7 @@ typedef struct uioc { dma_addr_t pthru32_h; struct list_head list; - void (*done)(struct uioc*); + void (*done)(struct uioc *); caddr_t buf_vaddr; dma_addr_t buf_paddr; diff --git a/drivers/scsi/megaraid/megaraid_mbox.h b/drivers/scsi/megaraid/megaraid_mbox.h index d2fe7f6..3c16d38 100644 --- a/drivers/scsi/megaraid/megaraid_mbox.h +++ b/drivers/scsi/megaraid/megaraid_mbox.h @@ -189,7 +189,7 @@ typedef struct { dma_addr_t mbox_dma; spinlock_t mailbox_lock; unsigned long baseport; - void __iomem * baseaddr; + void __iomem *baseaddr; struct mraid_pci_blk mbox_pool[MBOX_MAX_SCSI_CMDS]; struct dma_pool *mbox_pool_handle; struct mraid_pci_blk epthru_pool[MBOX_MAX_SCSI_CMDS]; diff --git a/drivers/scsi/megaraid/megaraid_mm.c b/drivers/scsi/megaraid/megaraid_mm.c index 864cbb6..234885c 100644 --- a/drivers/scsi/megaraid/megaraid_mm.c +++ b/drivers/scsi/megaraid/megaraid_mm.c @@ -582,7 +582,7 @@ static uioc_t * mraid_mm_alloc_kioc(mraid_mmadp_t *adp) { uioc_t *kioc; - struct list_head* head; + struct list_head *head; unsigned long flags; down(&adp->kioc_semaphore); @@ -722,7 +722,7 @@ ioctl_done(uioc_t *kioc) { uint32_t adapno; int iterator; - mraid_mmadp_t* adapter; + mraid_mmadp_t *adapter; /* * When the kioc returns from driver, make sure it still doesn't diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 40c77bb..2b17529 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -4402,7 +4402,7 @@ int megasas_alloc_cmds(struct megasas_instance *instance) * Allocate the dynamic array first and then allocate individual * commands. */ - instance->cmd_list = kcalloc(max_cmd, sizeof(struct megasas_cmd*), GFP_KERNEL); + instance->cmd_list = kcalloc(max_cmd, sizeof(struct megasas_cmd *), GFP_KERNEL); if (!instance->cmd_list) { dev_printk(KERN_DEBUG, &instance->pdev->dev, "out of memory\n"); @@ -8150,7 +8150,7 @@ static int megasas_set_crash_dump_params_ioctl(struct megasas_cmd *cmd) */ static int megasas_mgmt_fw_ioctl(struct megasas_instance *instance, - struct megasas_iocpacket __user * user_ioc, + struct megasas_iocpacket __user *user_ioc, struct megasas_iocpacket *ioc) { struct megasas_sge64 *kern_sge64 = NULL; -- 2.7.4