Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 10 Apr 2021 10:55:01 +0200
From:   Greg KH <greg@kroah.com>
To:     SeongJae Park <sj38.park@gmail.com>
Cc:     akpm@linux-foundation.org, SeongJae Park <sjpark@amazon.de>,
        Jonathan.Cameron@huawei.com, acme@kernel.org,
        alexander.shishkin@linux.intel.com, amit@kernel.org,
        benh@kernel.crashing.org, brendanhiggins@google.com,
        corbet@lwn.net, david@redhat.com, dwmw@amazon.com,
        elver@google.com, fan.du@intel.com, foersleo@amazon.de,
        gthelen@google.com, guoju.fgj@alibaba-inc.com, mgorman@suse.de,
        minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org,
        peterz@infradead.org, riel@surriel.com, rientjes@google.com,
        rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com,
        shuah@kernel.org, snu@amazon.de, vbabka@suse.cz,
        vdavydov.dev@gmail.com, zgf574564920@gmail.com,
        linux-damon@amazon.com, linux-mm@kvack.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v27 07/13] mm/damon: Implement a debugfs-based user space
 interface
Message-ID: <YHFn5fOTIQQ4TXHA@kroah.com>
References: <20210408134854.31625-1-sj38.park@gmail.com>
 <20210408134854.31625-8-sj38.park@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210408134854.31625-8-sj38.park@gmail.com>
Precedence: bulk

On Thu, Apr 08, 2021 at 01:48:48PM +0000, SeongJae Park wrote:
> +static int dbgfs_fill_ctx_dir(struct dentry *dir, struct damon_ctx *ctx)
> +{
> +	const char * const file_names[] = {"attrs", "target_ids"};
> +	const struct file_operations *fops[] = {&attrs_fops, &target_ids_fops};
> +	int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(file_names); i++)
> +		debugfs_create_file(file_names[i], 0600, dir, ctx, fops[i]);
> +
> +	return 0;
> +}

Why do you have a function that can only return 0, actually return
something?  It should be void, right?

thanks,

greg k-h