Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp285732pxb; Sat, 10 Apr 2021 02:49:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw006SxgxUbJTEluqlRYc0eFj+/Y9so1OxE24INizM0re4nGuIR7R0e6rfDb7SvDdtJUWZh X-Received: by 2002:a17:902:9b8a:b029:e6:17bb:eff0 with SMTP id y10-20020a1709029b8ab02900e617bbeff0mr17208168plp.54.1618048156870; Sat, 10 Apr 2021 02:49:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618048156; cv=none; d=google.com; s=arc-20160816; b=RwHa4aHyDA0gQ1OKoy2jYLN5woG07OgoEBZINNIO8jKiZoGtrLmFjybrz+ySpVz3cZ RVXR/tKLAj51warOLrFQrDmX4Cx460Ounn5BwOxg4LvPyTOHn8g9WNgDW9ZayG8xR73x lS1Bk/SxJlbRZ6KHeDWcqOPYKjORXV4BVgYLu2pFnZXFO0IkUnpJCNI0uWRDqa+y+4ck Jy4DuRxbCAH5Eb1L+OlZi/YuZDlK1i5gMIamXOPA3Y8uSKyrZId8NtmIzkh4SWOAgOLE djHEkfr2gbmHYEAozUqDpK8YFmET+NFKjOrDrmEKQgCTEsx9MWoQqXuRxM5bB0FbdgMb /5Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Tvf19OXUBXZlFKKnhTg3hQs3cfovqzCzgW+ka1x1V7A=; b=SioEuy1abNN3bBHAmCdVn1Boq42GyxcuOHWEmnfc7/A8C4e5BpK+L4KiWoSiSsgxZl 1z30NFqTVV04+/stOzE2WEokP0tCXcWLDO/GeQj5gJ2AILkv59/uDuaOMxJMgd7n97ac 6/EVnucbA/MlPJ9QSBnu65ZJS2aUDvzqYcy4jYs6KipPwVd8y7f5fag22pjzgkWLhp0t b93955Do5g3FQTHD6bDEjbH/1LBv9bU7Ci2JzHbSiKFsW7/AcW21FuchsK0ctAyP+yZH eJmDCoTiAtUGCVLPsZ8Rtwu8fRyCpQc/S+16VFua/lEAylyBrDuAuIDrflPfDcEK49Mq eEWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=RtQILUdp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w9si5228459plc.384.2021.04.10.02.49.04; Sat, 10 Apr 2021 02:49:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=RtQILUdp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232254AbhDJJsM (ORCPT + 99 others); Sat, 10 Apr 2021 05:48:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbhDJJsL (ORCPT ); Sat, 10 Apr 2021 05:48:11 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E9EBC061762 for ; Sat, 10 Apr 2021 02:47:57 -0700 (PDT) Received: from zn.tnic (p200300ec2f1aea004ff424aef8172112.dip0.t-ipconnect.de [IPv6:2003:ec:2f1a:ea00:4ff4:24ae:f817:2112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 39E911EC0409; Sat, 10 Apr 2021 11:47:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1618048074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Tvf19OXUBXZlFKKnhTg3hQs3cfovqzCzgW+ka1x1V7A=; b=RtQILUdppQ3HWLrs1+lEOkyhYze2Gu6mUYmik1O3u8SXLUOecirHFe2r4o8IFrxeVMJ7HX ZCZgc0imZOjkRL8glZ2uTGJuiuq6XXnJ9PUO6LyzG5fouE9k0fjf72ONo6SyXTY4buPcrb IXXLv0qXb79VKueBdnsZgrG9ePl0wTQ= Date: Sat, 10 Apr 2021 11:47:52 +0200 From: Borislav Petkov To: Thomas Gleixner Cc: Feng Tang , Ingo Molnar , "H . Peter Anvin" , Peter Zijlstra , x86@kernel.org, linux-kernel@vger.kernel.org, rui.zhang@intel.com, andi.kleen@intel.com, dave.hansen@intel.com, len.brown@intel.com Subject: Re: [RFC 1/2] x86/tsc: add a timer to make sure tsc_adjust is always checked Message-ID: <20210410094752.GB21691@zn.tnic> References: <1617092747-15769-1-git-send-email-feng.tang@intel.com> <87y2dq32xc.ffs@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87y2dq32xc.ffs@nanos.tec.linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 10, 2021 at 11:27:11AM +0200, Thomas Gleixner wrote: > On Tue, Mar 30 2021 at 16:25, Feng Tang wrote: > > Normally the tsc_sync will be checked every time system enters idle state, > > but there is still caveat that a system won't enter idle, either because > > it's too busy or configured purposely to not enter idle. Setup a periodic > > timer to make sure the check is always on. > > Bah. I really hate the fact that we don't have a knob to disable writes > to the TSC/TSC_ADJUST msrs. That would spare this business alltogether. We have the MSR filtering and I'd *love* to add those MSRs to a permanent ban list of MSRs which will never ever be written to from luserspace. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette