Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp419797pxb; Sat, 10 Apr 2021 07:05:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzstts7HPx8tf9oN5aNhDSXBvkqARzpX590n6AxsIW5uhk6szju7afITVqZnBY8s9I0bL4B X-Received: by 2002:aa7:d699:: with SMTP id d25mr21004636edr.83.1618063523442; Sat, 10 Apr 2021 07:05:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618063523; cv=none; d=google.com; s=arc-20160816; b=GnusVVdwPMHt9GDFnchoNywjfxwuEhIcFY2B55cUMdb/029MYy14o8ongBKkIyg5F6 J2PNC2Ip6OpndrHnxtiGuN/WN8d5M2Ue3IyqyUPzkWPZ4wR/Tkd3QCaCGnRgXXxgtFS2 fCSTBGck9zEXFL519FMR0d6wE9FcCH2uvpOEmPDaIbQtRLrk5hWpEejK6CrWlcrDlXLO +3DcwYWEwxsxMhtQaWCH/QK15hhA4iYFNxvrd1iWnNXSnG+TDtXFXR0dQEmNSITsPzTQ iAoLzjLqmkccOFEFu3xTsOldpOY1bwxlXwnGzRzBasrrJc79LK3VgMixjTZjjfRRJMP7 bUzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=UTRoMYWu7B3vzsZI4O7CNoNxUFFoLf0PSrDyTW3BsS4=; b=Fzfo8/SxeqKV7t90+w0iJSNok0ME5bffWP805O4jKAb+w3sno4cAo/JBWWZr0L231u CjhUxqN/LjvSRs1aAJ/nXYTf7Umk4raRwKElN+7X6zcAyEZjnJsBBQV1AsTQ07P4qNr/ 9KILrEi41yyAGRPvMo01p9yPK3XWTDqNO4FP4mAcRM60IX4LHckAsbWn/o8W7jujzI53 0MUqL0wnMaHWhE1E4tzuB1xhcZoISTzVdFlUZ2Q4VS+JBKLrSAl+KyGekOy+YkR9u1Ki urpYjK9bmLfHZB/l/BBoB8dWYGtkG0qkamYoMQt//UKHHTiMV0syVFpfJ0fdcFrUdbES 1PaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id md27si1469773ejb.620.2021.04.10.07.05.00; Sat, 10 Apr 2021 07:05:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234797AbhDJOCJ (ORCPT + 99 others); Sat, 10 Apr 2021 10:02:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234759AbhDJOCI (ORCPT ); Sat, 10 Apr 2021 10:02:08 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67D4EC06138A for ; Sat, 10 Apr 2021 07:01:53 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVEBH-0000GW-Ez; Sat, 10 Apr 2021 16:01:47 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lVEBH-0008Cl-00; Sat, 10 Apr 2021 16:01:47 +0200 Date: Sat, 10 Apr 2021 16:01:46 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Thierry Reding Cc: Clemens Gruber , linux-pwm@vger.kernel.org, Sven Van Asbroeck , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring Subject: Re: [PATCH v7 4/8] dt-bindings: pwm: Support new PWM_STAGGERING_ALLOWED flag Message-ID: <20210410140146.5nlp5eczltezbyq2@pengutronix.de> References: <20210406164140.81423-1-clemens.gruber@pqgruber.com> <20210406164140.81423-4-clemens.gruber@pqgruber.com> <20210407053357.ok62rqpgyqou53m3@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dndaw2zk5osfq3kr" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dndaw2zk5osfq3kr Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Thierry, On Fri, Apr 09, 2021 at 02:27:34PM +0200, Thierry Reding wrote: > On Wed, Apr 07, 2021 at 07:33:57AM +0200, Uwe Kleine-K=F6nig wrote: > > On Tue, Apr 06, 2021 at 06:41:36PM +0200, Clemens Gruber wrote: > > > Add the flag and corresponding documentation for the new PWM staggeri= ng > > > mode feature. > > >=20 > > > Cc: Rob Herring > > > Signed-off-by: Clemens Gruber > >=20 > > For the record, I don't like this and still prefer to make this > > staggering explicit for the consumer by expanding struct pwm_state with > > an .offset member to shift the active phase in the period. >=20 > How are consumers supposed to know which offset to choose? And worse: > how should consumers even know that the driver supports phase shifts? I'm aware that we're a long way from being able to use this. The clean approach would be to get the offset from the device tree in the same way as the period. And in the meantime I agree that introducing a flag that allows to shift the active part in the period is a sane idea. So I suggest we concentrate on getting the details in the corresponding discussion straight. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --dndaw2zk5osfq3kr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmBxr8cACgkQwfwUeK3K 7AkjVQgAjo/Bp/amP5OhhbHAxsZaKUXnsIuqDl25vhizVzvUI1359jMQ4GUWhrjS vW2pyfjftqYGuFf7y6ePoJSGxFMuRKm6Xw82MNmATDKseTDsILkFuZX/5AKaHg7D RlRQtxvLwYE+FVyCy/LHTuqR9w8cRzmuVFXIpFXYE4SeAFEgMUfA4YcuBiIqbqEs pOqC38xat2HpMmpqTrUNZfoJYZy48aB1D/u/o1HmYPJ+VUEo03XZazuFzxuV/iyx BSLTZuIxhMpO0jJjPgv7tnR7GDqZnWlzDVzI6dWgiT5iAh9S4gLYDlyzzdu2wmsA rmZCk7YDVwaVRJygGA5dmqLQVMkZwg== =nMwu -----END PGP SIGNATURE----- --dndaw2zk5osfq3kr--