Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp430135pxb; Sat, 10 Apr 2021 07:21:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJIqN4cf5Lnf00Q42ok0gr2x6LCGuFASH8kjYa7dJlbZWwYFGwfZDdZ96Zuo8NWvgbVHAr X-Received: by 2002:a17:906:2a16:: with SMTP id j22mr20406296eje.247.1618064506771; Sat, 10 Apr 2021 07:21:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618064506; cv=none; d=google.com; s=arc-20160816; b=loC5HJhycM+ekUfeRY9NAp+2Fs0E+G6DzJ/lVL/Hgvp6QopGd4YUP8G6Slbyl+me6q OcjIZZdxTcnUr6B2SPWdnNk52wrzmVU+47nm4iuHLWRSNWCfpg5BQXmGXTYrANGu9EWN ukKOh3b+qgorNTstWP/A8I3/lsZI433hng2/2/DhnuRO5oDxWHCaHnzgtqgiKdiHSoBE gaERKhM/hgkKxDhbGTItK3dp4toX0AV49P7pwt/osluP9sGnolTfmw2shgxpWzwmsXml qGTqImhwBNZ/Ke2uOpTgO+IL9XC6hNTF7/A5KjHie1eOfiDbt8wfp2N3s7svdSZ2RUIX JnDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:subject:reply-to:cc:from:to:dkim-signature:date; bh=9IwoH2UcLoIb4zzjDMXjFYQvN8/nnZXjHg+Ev5D0vqQ=; b=X9Rfe8AOCxNy/Shhc+umwPnIP39kJbkd0GBPRBGcb91x7E0QABy1csws6S1/BBJ08e mShX7PPJ/A4aSGkG3erYVD6Xb2i/s5T9utBZUms46HotvttcgzTUgSV3J7rHBxQPxgEv ZHZFxkKGMEyAtTkR+fUI8HppGvqIZWcqLKJvRIvWmZPR2Tx+dZaCl+XR5HRqOsKkGKP+ XiewZ8Ty3ow3QEvQWa/CgAE9JPjpBu47PHopSbieWepFAmUeVZPCOf9H8K4vLclLcQRS QDOp31dGnxupgmZo61dpGLxjWZcEnwKTF5ljuT/GEM4Ny0aCqR796ING3M0b7cm6MBcO /WOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bryanbrattlof.com header.s=protonmail3 header.b=pB8VcD1Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bryanbrattlof.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qq23si4157305ejb.505.2021.04.10.07.21.23; Sat, 10 Apr 2021 07:21:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@bryanbrattlof.com header.s=protonmail3 header.b=pB8VcD1Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bryanbrattlof.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234754AbhDJOUo (ORCPT + 99 others); Sat, 10 Apr 2021 10:20:44 -0400 Received: from mail-40136.protonmail.ch ([185.70.40.136]:51437 "EHLO mail-40136.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234519AbhDJOUn (ORCPT ); Sat, 10 Apr 2021 10:20:43 -0400 Date: Sat, 10 Apr 2021 14:20:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bryanbrattlof.com; s=protonmail3; t=1618064427; bh=9IwoH2UcLoIb4zzjDMXjFYQvN8/nnZXjHg+Ev5D0vqQ=; h=Date:To:From:Cc:Reply-To:Subject:From; b=pB8VcD1Y+IhvvVvC99JSiSxDGrqsB+sQEkZEqu3DKpuoh1aj9v5atmGpAxgj854/A /q2aen4oPcVSnFWudSbxZHOJiZYIouCfNv564UnIqAXQr4xA1DBDg30IkD0Z3o+u01 UDG3yY8a8eyxQ9Tfbawr5MN7jQz5Oprn1aDlPWRCwXYxquBjR9SV8jKRHzpIyt3tfa gOQdtXognDu7MGUzPQI+ieD7xT4MyRwv2q9nQLqg20SUjiuFbBCWtBiCaHtK/tjtPu i0QzHM6SnBzWgMP+tfUA1cyZmVya4KsQSQUhNhIMSuT0YivcjdHs6jZEJNthPBM+xX dgX/AWLmf+HBQ== To: Greg Kroah-Hartman , Hans de Goede , Larry Finger From: Bryan Brattlof Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Bryan Brattlof Reply-To: Bryan Brattlof Subject: [PATCH v2] staging: rtl8723bs: remove unnecessary goto jumps Message-ID: <20210410141945.424238-1-hello@bryanbrattlof.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The next instruction for both 'goto exit' jump statements is to execute the exit jump instructions regardless. We can safely remove all jump statements from __init rtw_drv_entry() Signed-off-by: Bryan Brattlof --- Changes from: v1: removed unnecessary edit of DBG_871X_LEVEL drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index 9fd926e1698f..39b6d4b6dec4 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -517,12 +517,8 @@ static int __init rtw_drv_entry(void) =09if (ret !=3D 0) { =09=09sdio_drvpriv.drv_registered =3D false; =09=09rtw_ndev_notifier_unregister(); -=09=09goto exit; =09} =20 -=09goto exit; - -exit: =09DBG_871X_LEVEL(_drv_always_, "module init ret =3D%d\n", ret); =09return ret; } @@ -540,6 +536,5 @@ static void __exit rtw_drv_halt(void) =09DBG_871X_LEVEL(_drv_always_, "module exit success\n"); } =20 - module_init(rtw_drv_entry); module_exit(rtw_drv_halt); --=20 2.27.0