Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp431640pxb; Sat, 10 Apr 2021 07:24:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7KF1zNBXuY0/hAVFpy/2Hh7S8u0xO10N1fIu/4d0CpOX3S33xz1ih1umed0dAQ8A7C3gD X-Received: by 2002:a17:902:8c92:b029:e8:fa73:ad22 with SMTP id t18-20020a1709028c92b02900e8fa73ad22mr487074plo.66.1618064677852; Sat, 10 Apr 2021 07:24:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618064677; cv=none; d=google.com; s=arc-20160816; b=taBskGRWkJT1yqWUPojfetnnqHqkOsMbXW4S44FKd7TXlRnvD0a6jgx+mADEvGsrit fika3fiJDTUIFKOoyajMZ8vc46Y+owa7H3T6ms+JHLYoxHp4IQ6I1BhUEXO3p+Vjx/us sgU1+ImqONI9mMU10Y6JaoNMRtLGdXJtsx6JoVnsXjkVCYTTao8dQQ1wAbkSnlWA3Fmf KunsICqeOwPlaNsN4umgITXbTIcH86cwQJ9M1tYz7cqz8fi7mOXk6KCjLBPrVlbrqV8c EihPO2bJvr0nhxviJ8xe2EyQIKW3UtP6r4Cwt6k+Ed8qBnAwF3/0z6ofPiI0hAgX+82I vnSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Q5nuHsBBM9Uu1NfcSwY0BeNDKPAr9Mc7yGwZ1gPZKnI=; b=kN53L3vIaf5BItb9EwVmBWRpPxuhWUJ3QTOX6unCUKoJJ/j0UNzhhWHGmansUqryoo 7pjmAoQrQTnGj2XmA55+v4Xusm7vV0h7darybJQR0mrwnZRI85ZoEXfDwJT5f9a6c/H4 TfQglaC6kG87B3gd7CqDX+8kjgE8kNyClurVsrcyuyWBOfzrfDFQNwnLdqYK6MJPQoPD z2yhZa0icyW1dq9oI3IP7/vvj20E3KvAvev5cF6xq946jIbYq5GL1nGmMVhCHWaExcgQ Mohdm888OloEqegmYUiq7HwPGPNkh3EielS6fn5jUeQikr/52MX/oINKLELg7KHhsRcJ v3KA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nKprcCW1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 186si6377590pgc.590.2021.04.10.07.24.26; Sat, 10 Apr 2021 07:24:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nKprcCW1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234909AbhDJOYB (ORCPT + 99 others); Sat, 10 Apr 2021 10:24:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235056AbhDJOVu (ORCPT ); Sat, 10 Apr 2021 10:21:50 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 265EFC06134C for ; Sat, 10 Apr 2021 07:21:18 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id z1so9791730edb.8 for ; Sat, 10 Apr 2021 07:21:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q5nuHsBBM9Uu1NfcSwY0BeNDKPAr9Mc7yGwZ1gPZKnI=; b=nKprcCW1KTc/ZmDN5ZQEAry5+/nQAra+VVTkkuAbas6WuVdFCJ5fZvp3vXivJT0DM5 dp18WmeGkl3zuj6UxxceNPQ8M/d0sih/Ac4iUX5J0Vjir+Tk2jLTqUrxcLh5VNGb/LRp OljX66TtyEMSo3mg6/apkaUJOMWXtFcfJKHNvS7mE799ijil+vGRQmO6NJL/0W3FfMK7 36Ng16iUJ7o9uHFFaW+VcvuCqM0PTyktNDO971wVAVo4Plfn9aoleub93Elf6Cmg7yk2 0J18SHspXPBPGol0Ul9S2rSTCfooV5bLdjx3aDmAOMyvBnI4iIKLt2IVVKg5R6Y/J71V y5jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q5nuHsBBM9Uu1NfcSwY0BeNDKPAr9Mc7yGwZ1gPZKnI=; b=C1dXfH2XU7NHuGbq0zuqEQwt1OXx9KYNMhlnHQIUagpiHDLypO8ag0gdi9a8RDNc3P /ZHMIACUg+gWdkdMfwenH5t9Lk8bBm86RiAFQNCc2NrJ39McKPAURRALbTbczzc2epuz ZvzbeJSMiM4ZTpXcp5kRGhgGcu60xuDxq2eoDYR9JoyUjCoWgjOerhezoNRO+oV7JP1l eDOVSjkuYtu75YrokXXujSaHIVT3bC1dUFoWcotGW41azYiWOWSO+vvkqVkVaW0Dgx8B p6aeHf9Gjcf7XbrhXme3RUSxKxRgxdj312oxBqwbY1RDaAm2jBuI5rpmVtGYoOwE0nLP vctw== X-Gm-Message-State: AOAM532zZH1Sxw+PotEJgLHxr8uq9zkoSW5xNqs2PFOrrjjU8x5dmTR9 QxbtnhYTwOVrvtgEt88ig66fgiFD9m74pQ== X-Received: by 2002:aa7:db9a:: with SMTP id u26mr21776965edt.292.1618064476704; Sat, 10 Apr 2021 07:21:16 -0700 (PDT) Received: from agape ([5.171.81.28]) by smtp.gmail.com with ESMTPSA id df8sm3270777edb.4.2021.04.10.07.21.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Apr 2021 07:21:16 -0700 (PDT) From: Fabio Aiuto To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 23/25] staging: rtl8723bs: fix comparison to true issue Date: Sat, 10 Apr 2021 16:20:36 +0200 Message-Id: <680d86950d760003a694f8880c0a912a9d815a5e.1618064275.git.fabioaiuto83@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fix following post-commit hook checkpatch issue: CHECK: Using comparison to true is error prone 136: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c: 2497: + if (psta->dot8021xalg != 1 || psta->bpairwise_key_installed == true) { Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c index 9c98820952e4..89a21eb63c0a 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -2491,7 +2491,7 @@ static int cfg80211_rtw_del_station(struct wiphy *wiphy, struct net_device *ndev plist = get_next(plist); if (!memcmp((u8 *)mac, psta->hwaddr, ETH_ALEN)) { - if (psta->dot8021xalg != 1 || psta->bpairwise_key_installed == true) { + if (psta->dot8021xalg != 1 || psta->bpairwise_key_installed) { list_del_init(&psta->asoc_list); pstapriv->asoc_list_cnt--; -- 2.20.1