Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp434072pxb; Sat, 10 Apr 2021 07:29:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkMCk/5zoKksV5cngbJMEEqxlV5Dk/DsjmXNwGKPSxpS/uo0uCN+hKOhmUhsz267k7Xd57 X-Received: by 2002:a05:6a00:168d:b029:23f:376d:a2f8 with SMTP id k13-20020a056a00168db029023f376da2f8mr17009989pfc.20.1618064956165; Sat, 10 Apr 2021 07:29:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618064956; cv=none; d=google.com; s=arc-20160816; b=RdI5V/COsEWa8z1HuQ0zcXj9c/iCCmzaPOx9LcpcvU9duOdiKkTL6Ct79ujiotmuik nADvveINb1gQ/jD/yZB6pvYE+PAnYt6RdBWggy0+4gWvJso9+gYiXFTfwjVK2iu5uk+D YItl3p6/9By8+zdKv3LyXRE+ue6N584hU2qgPnAdnZdeT85IyZe17+f1aHpBCHzb9ciD nTiDzsf/yYaShWcnahLCfubkNo6d0V0OAuAe6IUwfN2fKWstaEerEivsh2eIvHTOm2aW 3vGWSJW7WHPUvzo0NrxXipdRhS4liiFxk01BWyobl7MTyj5LjgpLBYk0XAptvSlQQP0w d5Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=KProHTMteQqyfugDQ+LnQOhC7iPIAi/WJOPp9pSBrvg=; b=GiWmOBCNRgsu4fXcF+D2jt+r/qm1ld5GwOjwd8EK23kD83X0touF8YguTn6imZKLdM EbNXFdD7HXOTu9Mw8iK/TgAxzuboSl9wY4G2r4Q3Lgy3gKuR/RBi+5bR8xJfIPhTaMdE kt6BSNJ17230nO/DZQCflYHkiUGU5t3IBmO8il5qjCqCiBxLppgWkeXTCyNTDknsUdec NDml3IqnRn4O51W5vxf6FZi3Pteym6zgqGphKldL6xM5FLsuJ/5chEtvgVXpWjuOdkln caxPRaPkR8h70z3nEMWhzV0Wqy3QWGkOZFH67Du7bTKGgsW27Y+hkpnG9uldIdYVchk8 aLUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QlnlAOsb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c11si4265347plg.286.2021.04.10.07.29.02; Sat, 10 Apr 2021 07:29:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QlnlAOsb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234738AbhDJO2l (ORCPT + 99 others); Sat, 10 Apr 2021 10:28:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:53486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234392AbhDJO2i (ORCPT ); Sat, 10 Apr 2021 10:28:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8914D6115B; Sat, 10 Apr 2021 14:28:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618064902; bh=vk1fqmBpzYPSIfjHRbqJl6UNW9VB0opCtMSgs5Q7qEs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QlnlAOsbehlgX6YKs0PIZQQBoYZGJkv69VvcLxO1MLn1zwHouCpPecJVeKtMSHoEB +HiVDvC0OIRDit54UsxNzIwqG2mezTwZkYH73EoHL3fB2znbp2GyIAlPtizicg9Lvt meTi+NqAicp7sPjiMQRtaRzzuKy21PeBY1G4LjHE= Date: Sat, 10 Apr 2021 16:28:19 +0200 From: Greg Kroah-Hartman To: Bryan Brattlof Cc: Hans de Goede , Larry Finger , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: remove unnecessary goto jumps Message-ID: References: <20210410141945.424238-1-hello@bryanbrattlof.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210410141945.424238-1-hello@bryanbrattlof.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 10, 2021 at 02:20:19PM +0000, Bryan Brattlof wrote: > The next instruction for both 'goto exit' jump statements is to > execute the exit jump instructions regardless. We can safely > remove all jump statements from __init rtw_drv_entry() > > Signed-off-by: Bryan Brattlof > --- > Changes from: > v1: removed unnecessary edit of DBG_871X_LEVEL > > drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > index 9fd926e1698f..39b6d4b6dec4 100644 > --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > @@ -517,12 +517,8 @@ static int __init rtw_drv_entry(void) > if (ret != 0) { > sdio_drvpriv.drv_registered = false; > rtw_ndev_notifier_unregister(); > - goto exit; > } > > - goto exit; > - > -exit: > DBG_871X_LEVEL(_drv_always_, "module init ret =%d\n", ret); > return ret; > } > @@ -540,6 +536,5 @@ static void __exit rtw_drv_halt(void) > DBG_871X_LEVEL(_drv_always_, "module exit success\n"); > } > > - > module_init(rtw_drv_entry); > module_exit(rtw_drv_halt); Any reason you removed this extra line? thanks, greg k-h