Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750981AbWJMOtE (ORCPT ); Fri, 13 Oct 2006 10:49:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750994AbWJMOtE (ORCPT ); Fri, 13 Oct 2006 10:49:04 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:15117 "EHLO spitz.ucw.cz") by vger.kernel.org with ESMTP id S1750981AbWJMOtB (ORCPT ); Fri, 13 Oct 2006 10:49:01 -0400 Date: Fri, 13 Oct 2006 14:48:44 +0000 From: Pavel Machek To: Burman Yan Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] HP mobile data protection system driver take 2 Message-ID: <20061013144844.GB5512@ucw.cz> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 919 Lines: 27 On Fri 13-10-06 15:10:29, Burman Yan wrote: > Hi, All. > > Thanks for the remarks on my previous post. > Here is the driver for HP Mobile Data Protection System > with the following changes: > 1) Fixed tabs from 8 spaces to tabs > 2) Removed C++ style comments > 3) Made some functions return void if their return value > is not checked anyway > 4) Moved the interface from proc to sysfs > 5) Made the sysfs interface similar to hdaps's so that > hdapsd could be used perhaps with small modifications > > I would like to hear your remarks on this version. Please inline patches. Is sysfs interface compatible to hdaps one? -- Thanks for all the (sleeping) penguins. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/