Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp576755pxb; Sat, 10 Apr 2021 11:56:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynbsXJFUUO523O7fMDutdKTPlzDpM0h4BM9UmSlSybr42J8Bpu+Ed3f14Y2sPVM+AcaUUg X-Received: by 2002:a17:906:1e8e:: with SMTP id e14mr21290180ejj.399.1618080963084; Sat, 10 Apr 2021 11:56:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618080963; cv=none; d=google.com; s=arc-20160816; b=tBr9PJu3py+7D2SCVuMYN87K6eTNas02w3+8LiL/rKY1Ymzbb0JVpWLo78VZk1dyFo 4tuE4bUEIlXae1bBeFjTVGP7nC6AFePfiSrO0uQXAARP6zpEq/W7JN1zERJTc5U+oZ+T 3BemXpLRv90excT/s0ibdGE7VaBYd5ai195h8zcWIEFTNgpTVOxIqEsIbOP9Hrxk+3Xm sz+yNYgHqa6cuQI0mWU28VsihG/qiuhwhZJNfPABiSsPHQ4IVWT6Q0IA+MtQ/z/Xtwcc BgL7+P2LGPTHM1HgfDhgwIJBN6asGQiHcgaHmXggbGvazmoUz7PuqouDrLYM3RuFz1Ic XGwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=EleD3XLbG1pirBgBbfEFVNTQXRxnWegUVdudqUcRuxU=; b=oe8gksI7TzSVFJEqhFs+rlbsw6lgV/rITm7nLW8vic1D5G4dyiaSU8NhOY434Jk9sj b+FwBddcWR9kWq1xzKFlv86kPZpGcaQSjErxSI/HLs+UloZ7U94jrQ1BmwBWwf00hYf2 vu9DAnhP0eHZYToTfcBpFuP11IXo/1788xaXxBehdhxuiQu9lBQjau9ZeUklkthTfihw R5nk+QrpmSHmioBl47gZwY9+ugxeEGYEZvIMMHWj8gR2Bln/mvOibpA8I0lsH1jScxGx MevylJMJYQJRMPoGzomFe7HWWxgImmH/D5lzcOz0QUnP4k7oEI8tvQ5r0OPWpOJrg1QW OPxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z18si4298327edb.55.2021.04.10.11.55.40; Sat, 10 Apr 2021 11:56:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234988AbhDJSwz (ORCPT + 99 others); Sat, 10 Apr 2021 14:52:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234983AbhDJSwz (ORCPT ); Sat, 10 Apr 2021 14:52:55 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4143EC06138A for ; Sat, 10 Apr 2021 11:52:40 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVIiX-0007yN-2k; Sat, 10 Apr 2021 20:52:25 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lVIiU-0007JE-6g; Sat, 10 Apr 2021 20:52:22 +0200 Date: Sat, 10 Apr 2021 20:52:22 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Nobuhiro Iwamatsu Cc: Rob Herring , Thierry Reding , Lee Jones , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, punit1.agrawal@toshiba.co.jp, yuji2.ishikawa@toshiba.co.jp, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support Message-ID: <20210410185222.4tfpgm2hcka26e6g@pengutronix.de> References: <20210409230837.1919744-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20210409230837.1919744-3-nobuhiro1.iwamatsu@toshiba.co.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fahlkkulnmz2naui" Content-Disposition: inline In-Reply-To: <20210409230837.1919744-3-nobuhiro1.iwamatsu@toshiba.co.jp> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fahlkkulnmz2naui Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, one more comment: On Sat, Apr 10, 2021 at 08:08:37AM +0900, Nobuhiro Iwamatsu wrote: > +static inline struct visconti_pwm_chip *to_visconti_chip(struct pwm_chip= *chip) all functions but this one start have the common prefix "visconti_pwm_". I like the concept of a common prefix and so you could rename this function to visconti_pwm_from_chip or similar. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --fahlkkulnmz2naui Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmBx8+IACgkQwfwUeK3K 7Ak7gQf9HBeqidP4ZBFq3cdE0CKBXmwUW4sbkRbVmfGiXkxxB2KLmLil0nuk+hiP rUWJtqRO4E5nt7DUe+s0zLC9dDQAiUHwRkDmx8ZUrMSQAXjvdlwxtO/cT40MkG+N CFxLPGM8XxvnA75X0PGiBK3ecYL1+jTX2bhwGICZfF1G6bxRC/24v7+DcjhEVjtC Mdg/+aRCqh3zL8zel/2FYXOrt2S9pJJFnFVCZTFVZEqfbX7nmdhgWIwY1oL7IGB8 QYzkfsUsGgZ8SY9/GQpWzpL+VinIkOLb5QMX4ZNVtftbm5dUwJJjtuJcopg3iOIX fGVmqJS8M1DufMeNBAhDkMeW2gLMDQ== =+J1z -----END PGP SIGNATURE----- --fahlkkulnmz2naui--