Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751192AbWJMPaI (ORCPT ); Fri, 13 Oct 2006 11:30:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751216AbWJMPaI (ORCPT ); Fri, 13 Oct 2006 11:30:08 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:4320 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1751192AbWJMPaG (ORCPT ); Fri, 13 Oct 2006 11:30:06 -0400 Subject: Re: [linux-pm] Bug in PCI core From: Arjan van de Ven To: Alan Cox Cc: Alan Stern , Adam Belay , Benjamin Herrenschmidt , Greg KH , linux-pci@atrey.karlin.mff.cuni.cz, Linux-pm mailing list , Kernel development list In-Reply-To: <1160753187.25218.52.camel@localhost.localdomain> References: <1160753187.25218.52.camel@localhost.localdomain> Content-Type: text/plain Organization: Intel International BV Date: Fri, 13 Oct 2006 17:29:50 +0200 Message-Id: <1160753390.3000.494.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1170 Lines: 29 On Fri, 2006-10-13 at 16:26 +0100, Alan Cox wrote: > Ar Gwe, 2006-10-13 am 10:29 -0400, ysgrifennodd Alan Stern: > > > I'd like to propose that we have the pci config sysfs interface return > > > -EIO when it's blocked (e.g. active BIST or D3cold). This accurately > > > reflects the state of the device to userspace, reduces complexity, and > > > could potentially save some memory per PCI device instance. > > > > Could you resubmit your old patches and include a corresponding fix for > > this access problem? > > And then you can fix the applications it breaks, like the X server which > does actually want to know where all the devices are located in PCI > space. > .. but which could equally well mmap the resource from sysfs ;) also the thing this patch does is ONLY when the device is effectively off the bus return -EIO. One can argue that -EAGAIN is nicer since it's only a temporary condition though.... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/