Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 11 Apr 2021 17:24:43 +0530
From:   Mitali Borkar <mitaliborkar810@gmail.com>
To:     Hans Verkuil <hverkuil@xs4all.nl>
Cc:     clabbe@baylibre.com, mchehab@kernel.org,
        gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        outreachy-kernel@googlegroups.com, mitali_s@me.iitr.ac.in
Subject: Re: [PATCH] staging: media: zoran: reduce length of a line
Message-ID: <YHLjg3U1M358bBxh@kali>
References: <YG9zvMnYlZVbJhQn@kali>
 <003b2d17-2fe4-c3f3-6b1e-60d0301a1413@xs4all.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <003b2d17-2fe4-c3f3-6b1e-60d0301a1413@xs4all.nl>
Precedence: bulk

On Fri, Apr 09, 2021 at 09:26:48AM +0200, Hans Verkuil wrote:
> Hi Mitali,
> 
> Something to improve:
> 
> On 08/04/2021 23:21, Mitali Borkar wrote:
> > Reduced length of a line which exceed the 100 columns limit by splitting
> > the line into two statements and commenting it with '*'
> > Reported by checkpatch.
> > 
> > Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> > ---
> >  drivers/staging/media/zoran/zr36060.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/media/zoran/zr36060.c b/drivers/staging/media/zoran/zr36060.c
> > index 4f9eb9ff2c42..035634fc1c6d 100644
> > --- a/drivers/staging/media/zoran/zr36060.c
> > +++ b/drivers/staging/media/zoran/zr36060.c
> > @@ -249,7 +249,9 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 };	//table idx's AC
> >  static const char zr36060_decimation_h[8] = { 2, 1, 1, 0, 0, 0, 0, 0 };
> >  static const char zr36060_decimation_v[8] = { 1, 1, 1, 0, 0, 0, 0, 0 };
> >  
> > -/* SOF (start of frame) segment depends on width, height and sampling ratio of each color component */
> > +/* SOF (start of frame) segment depends on width,
> > + * height and sampling ratio of each color component
> > + */
> 
> See the coding style guidelines: the preferred style for long comments is:
> 
> /*
>  * text
>  * text
>  */
>
I have sent v2 patch two days ago and I have not got reply till now,
Should I resend this?

> Regards,
> 
> 	Hans
> 
> >  static int zr36060_set_sof(struct zr36060 *ptr)
> >  {
> >  	char sof_data[34];	// max. size of register set
> > 
>