Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: f9upS+UTTlOInoyyfcuCvJeGYCU+CHF/OxnYQt9UWhjQiNfdqPdUlUxb7YvTSC1A643H7CM3yo
 OZB0xCu8Ilgg==
IronPort-SDR: muuYQBEec/nm4lJTFq5kEdfvwsFQ3Xli2/vfZ5JI0OkN+3BmshVlST9fseMmIbl4DNYzId3+wj
 +1EMe0+Mmk+A==
Message-ID: <ceb25b0000013f1c3e89d772c62b5e967a032446.camel@linux.intel.com>
Subject: Re: [PATCH] HID: hid-sensor-custom: remove useless variable
From:   Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, jikos@kernel.org,
        benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Sun, 11 Apr 2021 09:06:35 -0700
In-Reply-To: <20210411145635.3c6b48d1@jic23-huawei>
References: <1617952508-47150-1-git-send-email-jiapeng.chong@linux.alibaba.com>
         <4079bb49a9c0022603abeffcdaec32208f449e51.camel@linux.intel.com>
         <20210411145635.3c6b48d1@jic23-huawei>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sun, 2021-04-11 at 14:56 +0100, Jonathan Cameron wrote:
> On Fri, 09 Apr 2021 11:19:12 -0700
> Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote:
> 
> > On Fri, 2021-04-09 at 15:15 +0800, Jiapeng Chong wrote:
> > > Fix the following gcc warning:
> > > 
> > > drivers/hid/hid-sensor-custom.c:400:7: warning: variable ‘ret’
> > > set
> > > but
> > > not used [-Wunused-but-set-variable].
> > > 
> > > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>  
> > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com
> 
> Perhaps better to return ret if it is non zero?
> I can't immediately figure out if there is a reason we know that
> can't
> happen.
Only time it can fail when there is no report descriptor or the field
index is >= report->maxfield.
But since the attribute is registered from the report descriptor and
index, this can't happen.
But we can enhance sensor_hub_set_feature() to fail when
 hid_set_field() fails. There is one case where field->logical_minimum
< 0  and value is out of range.

Thanks,
Srinivas


> 
> Jonathan
> 
> > > ---
> > >  drivers/hid/hid-sensor-custom.c | 5 ++---
> > >  1 file changed, 2 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-
> > > sensor-custom.c
> > > index 2628bc5..e430673 100644
> > > --- a/drivers/hid/hid-sensor-custom.c
> > > +++ b/drivers/hid/hid-sensor-custom.c
> > > @@ -397,15 +397,14 @@ static ssize_t store_value(struct device
> > > *dev,
> > > struct device_attribute *attr,
> > >  
> > >  	if (!strncmp(name, "value", strlen("value"))) {
> > >  		u32 report_id;
> > > -		int ret;
> > >  
> > >  		if (kstrtoint(buf, 0, &value) != 0)
> > >  			return -EINVAL;
> > >  
> > >  		report_id = sensor_inst->fields[field_index].attribute.
> > >  								report_
> > > id;
> > > -		ret = sensor_hub_set_feature(sensor_inst->hsdev,
> > > report_id,
> > > -					     index, sizeof(value),
> > > &value);
> > > +		sensor_hub_set_feature(sensor_inst->hsdev, report_id,
> > > index,
> > > +				       sizeof(value), &value);
> > >  	} else
> > >  		return -EINVAL;
> > >