Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1215992pxb; Sun, 11 Apr 2021 11:21:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyB26iOndiaGM7PY6mzCKml+gtfSSNLxqQkPZ6Rjok/Azo4RTkx5ZBYMryZBVLB9wRGoE3 X-Received: by 2002:a17:90a:3ee1:: with SMTP id k88mr25484496pjc.174.1618165271069; Sun, 11 Apr 2021 11:21:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618165271; cv=none; d=google.com; s=arc-20160816; b=gz3cMpMEkDNF91rwGvhOrA/kClRyM5SxhWke8lBVhphbMkjJqEE2oUEjkWrSdMnfjr 9olmrG00XrL7zF8eNbXa2JyCuPlDl82+3Kwek9uHEYgLShSVZs6ThqwixDKvhBHO9V/j ocPZlDK9NfbYJ5K+C2hPhvbamcpgoNGrA3SttjaNLD4QDh0eAjzUSl1+YeVBOzKkQR4C zJokjbLxzRqf9KvRS1kxzyHVb8Hs+0olEOKEazODQ4/PipYbXH6jlL1jBkLzUiv8vNzF g1vT0C12JXvntTzUrB1xEtIWaeKGBsJ4sqwIoS/4wedRBP3DMsxCxub0Q8vFp+jBA667 nnZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=VtauxmK8yAEqFVdfGU9f3e+pdmQgG0gKS9QlYz54BgM=; b=UaFrB0lWjYytiNqUsUW0cXAG3CdDsN4NTQgS8QXhx355+iG+yRDEpSC9v227XPesOQ ZuC+zNqSy73KIYe/PH74X8SZzTbzTwkeTFNjs6Ams4JvUe8OKHaa4ltg6dCsYyY1KD6v QfCynPo6hDOjueATurigtQlAs34PnNQOg8xk+HJKJ5vrgZWRiz/hRpG1iI4UlFWxlcyq N5oz4tvH3j1yEQCboqDK7dUWDrmhApaQyXDF1U2pbwJF8aUilMKUt/4+qYhMq93188X6 DgvhWJhNjF7yKXpwHEnU9WFLZygaoGIWD5iQAMXlGx7OKN8KdWy3SuO0bwREs7un/N0C Ebrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siol.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w191si14085051pfd.304.2021.04.11.11.20.58; Sun, 11 Apr 2021 11:21:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siol.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235739AbhDKSTB convert rfc822-to-8bit (ORCPT + 99 others); Sun, 11 Apr 2021 14:19:01 -0400 Received: from mailoutvs49.siol.net ([185.57.226.240]:52558 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235229AbhDKSTB (ORCPT ); Sun, 11 Apr 2021 14:19:01 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id E0BF9525531; Sun, 11 Apr 2021 20:18:42 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta09.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta09.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id eZShPbwdXxkD; Sun, 11 Apr 2021 20:18:42 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id A100952552D; Sun, 11 Apr 2021 20:18:42 +0200 (CEST) Received: from kista.localnet (cpe-86-58-17-133.cable.triera.net [86.58.17.133]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id F1B3B525539; Sun, 11 Apr 2021 20:18:41 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: lujialin4@huawei.com, Mauro Carvalho Chehab , Maxime Ripard , Chen-Yu Tsai , Philipp Zabel , Lu Jialin Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] media: sun8i: Fix PM reference leak in deinterlace_start_streaming() Date: Sun, 11 Apr 2021 20:18:41 +0200 Message-ID: <2184866.DZomrXFPLt@kista> In-Reply-To: <20210408133630.56299-1-lujialin4@huawei.com> References: <20210408133630.56299-1-lujialin4@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne Ĩetrtek, 08. april 2021 ob 15:36:30 CEST je Lu Jialin napisal(a): > > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. > > Reported-by: Hulk Robot > Signed-off-by: Lu Jialin Acked-by: Jernej Skrabec Best regards, Jernej