Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1276631pxb; Sun, 11 Apr 2021 13:55:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpxepo/TY5Fzyg4f9Zn1czR69ZRJ62Z8SSkmkufrGnsuvFNhQYOEAXVHipTh6ne/8q+xuj X-Received: by 2002:a17:906:2307:: with SMTP id l7mr25271861eja.27.1618174555118; Sun, 11 Apr 2021 13:55:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618174555; cv=none; d=google.com; s=arc-20160816; b=k3VyOAtRZxPR4BKjlD1rSDXOy1tjf3IfDZwyaWVpor5xIEMdAMz4wyiP/NitM+HK9V +FKwoErJCX4t4fBO0f8jKCJj+Ynsye0SLWGeIvcpzftTL22uTCl2J0QE0Xod0ziZ6g2c coAcXJH/NvWCoDdMq+iF4kDul0PmyLZwB67EuoWMlJWE55I9dqlGviUTPxQqUlKxMx/j nJcgduEIptoKxVzxIy5vjDU/z1VQTeRWhzPcFWAXg67qP2pTBnAM0r5XofxU8sDGJsyc QUlfd4NgCl5dCagv0oEP6mpdtj8LnzAEj4Q4xvfEBr4nPCI67VNic3iej8xC4g5PQ731 FlCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=eS4ksG7t8o2nshOeR/zWsD96ypCcvfx7l8Uv2XCWO0k=; b=pHuHRksQruWoNZjyAAI04J/34C7TqlRTjicQg/8em3wTWFHDE9SWViVJDIAIf4Imaa NTFbN/1ivFRYitMNBSU8aUB2WToOzkPudbrFdXw0Jdi7s+oby7U+xkXmHb2Ygz3yzZbC BDb819qnP67NMUNbbrzd7tG9UKEHJycz+HN+ocBj/04kr8dh3drfSq2sicCxVhnWw/D/ NfQ4ihSXwOhOtqECNHxlQQ3qLtjr0OLZrPMSjC4XsdbnLSxg1m7xQ9h2ChodpArjzEN/ 0R5vusSQ8tz0r88/3omINTq/ylZTr7n9xgY8Vt+YoO8hg2hP2jsGK+te1D4xrYq/1OMW 7j4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siol.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 25si953977ejy.309.2021.04.11.13.55.31; Sun, 11 Apr 2021 13:55:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siol.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235592AbhDKSQp (ORCPT + 99 others); Sun, 11 Apr 2021 14:16:45 -0400 Received: from mailoutvs38.siol.net ([185.57.226.229]:52300 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235284AbhDKSQp (ORCPT ); Sun, 11 Apr 2021 14:16:45 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Zimbra) with ESMTP id 362CC524A80; Sun, 11 Apr 2021 20:16:26 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta12.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta12.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Yh0Hz7uPS1UE; Sun, 11 Apr 2021 20:16:26 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Zimbra) with ESMTPS id ED9E0524AA4; Sun, 11 Apr 2021 20:16:25 +0200 (CEST) Received: from kista.localnet (cpe-86-58-17-133.cable.triera.net [86.58.17.133]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Zimbra) with ESMTPA id E1BAE524A80; Sun, 11 Apr 2021 20:16:24 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: xiangyang3@huawei.com, Mauro Carvalho Chehab , Maxime Ripard , Chen-Yu Tsai , Philipp Zabel , Xiang Yang Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Hulk Robot Subject: Re: [PATCH -next] media: sunxi: sun8i-rotate: fix PM reference leak in rotate_start_streaming() Date: Sun, 11 Apr 2021 20:16:24 +0200 Message-ID: <2001311.PWddzm8SjH@kista> In-Reply-To: <20210409064658.90493-1-xiangyang3@huawei.com> References: <20210409064658.90493-1-xiangyang3@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne petek, 09. april 2021 ob 08:46:58 CEST je Xiang Yang napisal(a): > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. > > Reported-by: Hulk Robot > Signed-off-by: Xiang Yang Acked-by: Jernej Skrabec Best regards, Jernej