Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1281899pxb; Sun, 11 Apr 2021 14:08:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/Ffbo37BYth9kDIF+QW8Ci90ucRv17LW0447AQ8M0hKGnLw4uCPawhIhejw3Gi+GwlWha X-Received: by 2002:a17:90b:30d2:: with SMTP id hi18mr1756241pjb.94.1618175336271; Sun, 11 Apr 2021 14:08:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618175336; cv=none; d=google.com; s=arc-20160816; b=QTQ1c2U1X6tVB/+cJmdPz9TflasgceIe+DGTiZfAlLf7i/LiQKZUsNN3ijO2CpK3Ae O4w6pAdzCweu5vm/uYAX5YpUyxy302vpIymf3kAl/c1KH+GETud+/blGL9jnfMtK+lf1 EAte2lxpP9bIluZzBkdV4JWZQI8W8yrYpsR+Uj22a8Q0L0cbfExW+idbVlmLdkH0nu79 kbEHTnmH3dCH6iLLz0bivPESRJ5vmwBCC0NlUEL3ma9p8kjEBU4yuNFz8yPye8r9ZlMK +c6c5qiPwTmrHnUH98A+em5mAjpBgM3XlKkYmvGATRQNzf6hNJyi0rtCn8FYgU7oOEbn cQug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=CLWRaO5ZqKnnKAniIlo1Keihq6ioiH5Ebgdd1JLKcuU=; b=Q5eXKDvhnfLuLLEQybl3k0uAHN1lSrzfk403YqcMX5tZTN4hRa3dy3mISrYyqO2Wc5 2FHcPjvzYwMGKNR/5D0FYLfOZ5eQlxJwFBp/XXDKViJOgPlIlFZTjEdx4koIPdud8zn3 nfpbh8OBMzSmUIoHfJ3hVRy8aXPV1JnDdzSgdpOK5SirpDiwdXY8Mgx69MRppQ+4Eb2y 4lUHl5x0OLuZJK44RVUD92WN5o7WCMAR1LzKz7/4XsS+KvuCWERxWqkKPb+kj8If4zaI IZPDcDBr1b4t5eE0mElnaQFa281nANjEHd5R9nZL8bn+/+SJf4Fwnd8ZLPo9Gw6DdWtS WC3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Tbw7JlML; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k6si10991178pjo.52.2021.04.11.14.08.42; Sun, 11 Apr 2021 14:08:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Tbw7JlML; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236306AbhDKSsf (ORCPT + 99 others); Sun, 11 Apr 2021 14:48:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235559AbhDKSse (ORCPT ); Sun, 11 Apr 2021 14:48:34 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09E20C061574 for ; Sun, 11 Apr 2021 11:48:18 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id z1so12417482edb.8 for ; Sun, 11 Apr 2021 11:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CLWRaO5ZqKnnKAniIlo1Keihq6ioiH5Ebgdd1JLKcuU=; b=Tbw7JlMLqgWsGYOF21ZRyS0bymgqTuwt4PVr2F6MnnlmvSonJJyx3KJmHrKSIJgy0e 0VSGrJeeZjQA8UFi9AJujw+qgIrazKf+HQJvj9gdTo/sxOmRGA4hnTuES41GB5bRgLKe Y0O8FTDiUJsJ/b/zTD/YbrElyMWoFnw/kcSRp3gusC0i7IfEvYfU5uz7FFz0TdW480+U 2r6wKpDhZDEVdqx1r9xSCZH9cS2vvR6ZTpbdALxJNFCcdBDCZKwKNM9kFZ6tECRO0y/8 OeYIRheFAKCmu5bHEr2MgkYjkf1Hfydp22y9uXpwRvJrLGK12O615ivS8iSfyFIm+RIr gHhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CLWRaO5ZqKnnKAniIlo1Keihq6ioiH5Ebgdd1JLKcuU=; b=iD/0l6/NjlFCixkCUAQTGwgBO0cMxv5pDrHbewZWKfKel46vFBgLNYDxaVJJp7lgEx Gio6kfcFg+Xo9tJA5BkvPuJSIqo/fJ3+4PTOQrYIBSkMJAO1Lw3kSVzOwKXQa42lPfCK KP75LCpD9z8KaOxrAHlRlId3B22tWLnh2jmx0L+TEss2TuNMKsAWN1LXfquo+KvoUoWq VCTyWoF6gtLu0/hTi6dr0khtG9DvcG7yY+cYux2YKvleR1UVkYzAD76avnEinRdc8ZkP IklwxcLQ+jHn5Owyx70AHK6nQgvC67A93Bcd+VtMZIDutwLsISigzG29cWr1MV8Rsolk mnig== X-Gm-Message-State: AOAM530RDPDRBxEOeBV7j3KSAwQZuKKcILbDU8xXA3S8ApZxoFy33kFG oFZ/HMJiFJNG5vJrjy84etT7xmk1VI9RNPS4 X-Received: by 2002:aa7:cb89:: with SMTP id r9mr26607291edt.245.1618166896788; Sun, 11 Apr 2021 11:48:16 -0700 (PDT) Received: from localhost.localdomain (host-95-237-55-30.retail.telecomitalia.it. [95.237.55.30]) by smtp.gmail.com with ESMTPSA id q18sm5069171edr.26.2021.04.11.11.48.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Apr 2021 11:48:16 -0700 (PDT) From: "Fabio M. De Francesco" To: Greg KH , outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: "Fabio M. De Francesco" Subject: [Outreachy kernel] [PATCH] staging: rtl8192u: Remove function Date: Sun, 11 Apr 2021 20:48:13 +0200 Message-Id: <20210411184813.22836-1-fmdefrancesco@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove cmpk_handle_query_config_rx() because it just initializes a local variable and then returns "void". Signed-off-by: Fabio M. De Francesco --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 40 ------------------------ 1 file changed, 40 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c b/drivers/staging/rtl8192u/r819xU_cmdpkt.c index 4cece40a92f6..d5a54c2d3086 100644 --- a/drivers/staging/rtl8192u/r819xU_cmdpkt.c +++ b/drivers/staging/rtl8192u/r819xU_cmdpkt.c @@ -249,46 +249,6 @@ static void cmpk_handle_interrupt_status(struct net_device *dev, u8 *pmsg) DMESG("<---- cmpk_handle_interrupt_status()\n"); } -/*----------------------------------------------------------------------------- - * Function: cmpk_handle_query_config_rx() - * - * Overview: The function is responsible for extract the message from - * firmware. It will contain dedicated info in - * ws-06-0063-rtl8190-command-packet-specification. Please - * refer to chapter "Beacon State Element". - * - * Input: u8 *pmsg - Message Pointer of the command packet. - * - * Output: NONE - * - * Return: NONE - * - * Revised History: - * When Who Remark - * 05/12/2008 amy Create Version 0 porting from windows code. - * - *--------------------------------------------------------------------------- - */ -static void cmpk_handle_query_config_rx(struct net_device *dev, u8 *pmsg) -{ - struct cmpk_query_cfg rx_query_cfg; - - /* 1. Extract TX feedback info from RFD to temp structure buffer. */ - /* It seems that FW use big endian(MIPS) and DRV use little endian in - * windows OS. So we have to read the content byte by byte or transfer - * endian type before copy the message copy. - */ - rx_query_cfg.cfg_action = (pmsg[4] & 0x80) >> 7; - rx_query_cfg.cfg_type = (pmsg[4] & 0x60) >> 5; - rx_query_cfg.cfg_size = (pmsg[4] & 0x18) >> 3; - rx_query_cfg.cfg_page = (pmsg[6] & 0x0F) >> 0; - rx_query_cfg.cfg_offset = pmsg[7]; - rx_query_cfg.value = (pmsg[8] << 24) | (pmsg[9] << 16) | - (pmsg[10] << 8) | (pmsg[11] << 0); - rx_query_cfg.mask = (pmsg[12] << 24) | (pmsg[13] << 16) | - (pmsg[14] << 8) | (pmsg[15] << 0); -} - /*----------------------------------------------------------------------------- * Function: cmpk_count_tx_status() * -- 2.31.1