Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1397181pxb; Sun, 11 Apr 2021 18:33:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGHdnLLnj17sAzYTfUJ7yDO1d1uSYSkHJQVcpTGa+Q1d7IlfNjXnhYuGL5BMuP+bVYFRav X-Received: by 2002:a17:906:ad81:: with SMTP id la1mr2490413ejb.74.1618191207015; Sun, 11 Apr 2021 18:33:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618191207; cv=none; d=google.com; s=arc-20160816; b=WrUzZcZUkqAubhhVQCPSxRdgdo2q9InSFEgvp5k2C0DzV2qtPAYGHDTw1yA5DZmHjz RJgD7j0rfpH2UWU8ZR2B2NasPSSRIgwS4zdAPcZLIViZlXtgcHX9/EHIbJYZh7ZN9p0N 3/O5OG+Yc5pbomvdwgtlEpfxmFGQZKOLAHtiCIWujsDe9ehFnsQxWtYx5xUMmTodz7Yv OlG8Jfy/3KZ4X+xWg2a8aWHeu7827WjeYvHTzh+ChbQV+WFyLYC0kOaJHA+/YPxBaXJN oxdpCg8jkewIXki5F/TAdPg5vH8pcxsFQ+N4PmnsLmBbj4hj3TfpmLkNEjzY0NGjrKI4 QoIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=EpGUBNlUjaSXjVPlfPzmm9xzDu1TJ2gxcyEpgmYKrVw=; b=Qnl6X2KS0LpX229r9rAQPaD5whyBohTkENQH7bOoaE1DBJTs0Qbxv7MOFlHZOZOBki bNzbW0+YNGAwU0v4Xf1ucobeaZCjzhOvKG5j3mbiDavB45Ku8I01vTfHyp72/OmwAl9T giH4bFAA79ZuJ54S58JFQDFjqUjgVAGS8o+tuU6S2ZJBck3SofwAwjgsbhvx+5BT6u+O GMYNt+i5C/Xft7aGTHkoPQfXu6NnLVK8s//RgQVDy+NRAHvgbBAUhFlCgeLTnvfVIhbV uPasHZRGYefsEz++TByiykZtmZtsHyENipGWmx7I59KGrc24T7QlRsjRVO75gaRbOUtq pCTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Z+qRvh4X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bq19si6929465edb.311.2021.04.11.18.33.04; Sun, 11 Apr 2021 18:33:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Z+qRvh4X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236292AbhDLBOT (ORCPT + 99 others); Sun, 11 Apr 2021 21:14:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21698 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236086AbhDLBOS (ORCPT ); Sun, 11 Apr 2021 21:14:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618190040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EpGUBNlUjaSXjVPlfPzmm9xzDu1TJ2gxcyEpgmYKrVw=; b=Z+qRvh4XKCMkh9Q8K/EdvEF8akp2tb5N9vsuwFGULQkUUeIBygHS1LHnEEFDmqztoG7cVq mykK2Ez0UQ+bfKSKFeldP7GWB06xJ1YvuTjnckcJ1RM5igAa/YG5u3qq2LhH6oOBjOyAN1 39vF6ej/lQq/DYlpN2y83OTJIEn7xUo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-317-r-22rNMiPPKYO7hR3mRLgA-1; Sun, 11 Apr 2021 21:13:56 -0400 X-MC-Unique: r-22rNMiPPKYO7hR3mRLgA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D7407107ACC7; Mon, 12 Apr 2021 01:13:54 +0000 (UTC) Received: from localhost (ovpn-13-33.pek2.redhat.com [10.72.13.33]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 00F3A13488; Mon, 12 Apr 2021 01:13:49 +0000 (UTC) Date: Mon, 12 Apr 2021 09:13:47 +0800 From: Baoquan He To: "H. Peter Anvin" Cc: Lianbo Jiang , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, x86@kernel.org, ardb@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dvhart@infradead.org, andy@infradead.org, kexec@lists.infradead.org, dyoung@redhat.com Subject: Re: [PATCH] x86/efi: Do not release sub-1MB memory regions when the crashkernel option is specified Message-ID: <20210412011347.GA4282@MiWiFi-R3L-srv> References: <20210407140316.30210-1-lijiang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/09/21 at 07:59pm, H. Peter Anvin wrote: > Why don't we do this unconditionally? At the very best we gain half a megabyte of memory (except the trampoline, which has to live there, but it is only a few kilobytes.) This is a great suggestion, thanks. I think we can fix it in this way to make code simpler. Then the specific caring of real mode in efi_free_boot_services() can be removed too. Thanks Baoquan