Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 23dfKJ5xcrYRFZ3F5MWmpWvqRQKZGj95NgRcdzPxUZQEdQH32LLw5cz7FCchBCaCsroqz7lbJv
 W4jy/n0WpoXg==
IronPort-SDR: n6uThAuu0JhtEm7/fJYJGpEV2nB9cTYvrTy+zJGZG95qwqzHtoGbmR3+eQh8un5QxAMgSVK11t
 OteXsn89D4gw==
Subject: Re: [PATCH v3 09/27] perf parse-events: Create two hybrid cache
 events
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com
References: <20210329070046.8815-1-yao.jin@linux.intel.com>
 <20210329070046.8815-10-yao.jin@linux.intel.com> <YHBa820crfHSIZuz@krava>
From:   "Jin, Yao" <yao.jin@linux.intel.com>
Message-ID: <00b56b3c-c88d-8340-e8b7-703f6023bf03@linux.intel.com>
Date:   Mon, 12 Apr 2021 09:15:34 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <YHBa820crfHSIZuz@krava>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Jiri,

On 4/9/2021 9:48 PM, Jiri Olsa wrote:
> On Mon, Mar 29, 2021 at 03:00:28PM +0800, Jin Yao wrote:
> 
> SNIP
> 
>> index 1bbd0ba92ba7..3692fa3c964a 100644
>> --- a/tools/perf/util/parse-events.c
>> +++ b/tools/perf/util/parse-events.c
>> @@ -458,6 +458,7 @@ int parse_events_add_cache(struct list_head *list, int *idx,
>>   	int cache_type = -1, cache_op = -1, cache_result = -1;
>>   	char *op_result[2] = { op_result1, op_result2 };
>>   	int i, n;
>> +	bool hybrid;
>>   
>>   	/*
>>   	 * No fallback - if we cannot get a clear cache type
>> @@ -517,6 +518,13 @@ int parse_events_add_cache(struct list_head *list, int *idx,
>>   		if (get_config_terms(head_config, &config_terms))
>>   			return -ENOMEM;
>>   	}
>> +
>> +	i = parse_events__add_cache_hybrid(list, idx, &attr,
>> +					   config_name ? : name, &config_terms,
>> +					   &hybrid);
>> +	if (hybrid)
>> +		return i;
> 
> please define 'ret' for the return value, i is confusing
> 
> thanks,
> jirka
> 

Previously I wanted to save a 'ret' variable, but yes it's confusing. I will define 'ret' in next 
version.

Thanks
Jin Yao

>> +
>>   	return add_event(list, idx, &attr, config_name ? : name, &config_terms);
>>   }
>>   
>> -- 
>> 2.17.1
>>
>