Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210409023349.3325907-1-qiulaibin@huawei.com>
In-Reply-To: <20210409023349.3325907-1-qiulaibin@huawei.com>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Mon, 12 Apr 2021 09:52:22 +0200
Message-ID: <CAPDyKFrwp6tbaHt6nctnTgppG5PsS2Hcb-BPhBT6N0-fmcpAWA@mail.gmail.com>
Subject: Re: [PATCH -next] mmc: owl-mmc: Remove unnecessary error log
To:     Laibin Qiu <qiulaibin@huawei.com>
Cc:     =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>,
        Manivannan Sadhasivam <mani@kernel.org>,
        YueHaibing <yuehaibing@huawei.com>,
        linux-mmc <linux-mmc@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linux-actions@lists.infradead.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 9 Apr 2021 at 04:24, Laibin Qiu <qiulaibin@huawei.com> wrote:
>
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/owl-mmc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> index 5490962dc8e5..3dc143b03939 100644
> --- a/drivers/mmc/host/owl-mmc.c
> +++ b/drivers/mmc/host/owl-mmc.c
> @@ -581,7 +581,6 @@ static int owl_mmc_probe(struct platform_device *pdev)
>         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>         owl_host->base = devm_ioremap_resource(&pdev->dev, res);
>         if (IS_ERR(owl_host->base)) {
> -               dev_err(&pdev->dev, "Failed to remap registers\n");
>                 ret = PTR_ERR(owl_host->base);
>                 goto err_free_host;
>         }
> --
> 2.25.1
>