Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1578797pxb; Mon, 12 Apr 2021 01:15:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7IOiG5gsEpKk6TLqamBB3Z5pRCIfQBOML+zxmf6QoW89ln3UdQGROGMCE9OPreLvfT2tj X-Received: by 2002:a17:906:7016:: with SMTP id n22mr16792379ejj.23.1618215338853; Mon, 12 Apr 2021 01:15:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618215338; cv=none; d=google.com; s=arc-20160816; b=a2mgUHgtK8GHBPVvBr+KHCXTiXYxVhS01at2Elxiyb/BMSCBiU5/Eqk5iFlXkZ3C2j vXebvTwyLPzCx+QAww5KDYau/lWSwfWAzCdbQLCxFIqV+OpaYn+Duqxy63KEEQHBeRy/ QxrRyCCvR01GVDIcroptwnMepn0aGEdgE7+DgRb7Vm/ZJ+YbAHBCUCd4KQYlZfViWBQa EMXRUkt0cJZIdQfut1dNkPTtuEXjr7NqiOHWkue9RcbL7VroXnJQO7E9ERc4GvM3eLm3 vgv1FCUJOhnBcPu4Ao4UkFoI/4WB6Or3ZSXQIXIOG7GYSfkkfo6aU6qHQU73j7Z9lWrU bE0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=T7FHk2HQBHc5VSqVjLNmR9or/aM4c0ePE1w7svA0EPo=; b=VRiRFFaOWgW/F4yd0vxBSRrd+QbCRcBU6WxT53aMd/519WeXN1RAnjR8gM+sLIlgxm JgJUFOCmSsdXX//vu7DeyC7CGyCb54DFOsEsDnpZkTqTMXiZVQq0AcMsLsl+Am2viZAT R6tddBmjneF7XySrx5oeofx7/vY+yYMHgGfwEsEdZvsQxt6cF7GRvHV+DlFtyr2n0u8p 4OlzPr4UCWmI4wfS+wwC4Ja9wFROV2fmotd2xn3oawhriiQ1eTKGbcvvytWodJbHhjiF E10W7X7cS4a7ws/qcBI2yK+00nZ2E8483tm/BFosc0OpeI+eBnIHcP20WrF9Ht9nkSON yocw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b19si7306755ede.447.2021.04.12.01.15.15; Mon, 12 Apr 2021 01:15:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237095AbhDLINj (ORCPT + 99 others); Mon, 12 Apr 2021 04:13:39 -0400 Received: from verein.lst.de ([213.95.11.211]:47521 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237012AbhDLINi (ORCPT ); Mon, 12 Apr 2021 04:13:38 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 8089C68C4E; Mon, 12 Apr 2021 10:13:17 +0200 (CEST) Date: Mon, 12 Apr 2021 10:13:17 +0200 From: Christoph Hellwig To: Peter Zijlstra Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, x86@kernel.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, chris@chris-wilson.co.uk, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, keescook@chromium.org, hch@lst.de Subject: Re: [PATCH 1/7] mm: Unexport apply_to_existing_page_range() Message-ID: <20210412081317.GA4372@lst.de> References: <20210412080012.357146277@infradead.org> <20210412080611.568192782@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210412080611.568192782@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 12, 2021 at 10:00:13AM +0200, Peter Zijlstra wrote: > There are no modular in-tree users, remove the EXPORT. > > This is an unsafe function in that it gives direct access to the > page-tables. > > Signed-off-by: Peter Zijlstra (Intel) Looks good, Reviewed-by: Christoph Hellwig