Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751783AbWJMSh5 (ORCPT ); Fri, 13 Oct 2006 14:37:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751799AbWJMSh5 (ORCPT ); Fri, 13 Oct 2006 14:37:57 -0400 Received: from smtp.osdl.org ([65.172.181.4]:57765 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751783AbWJMSh5 (ORCPT ); Fri, 13 Oct 2006 14:37:57 -0400 Date: Fri, 13 Oct 2006 11:28:21 -0700 From: Stephen Hemminger To: Adrian Bunk Cc: Andrew Morton , linux-kernel@vger.kernel.org, Stephane Eranian , sam@ravnborg.org Subject: Re: [PATCH] rename net_random to random32 Message-ID: <20061013112821.55c00b03@dxpl.pdx.osdl.net> In-Reply-To: <20061013181922.GB721@stusta.de> References: <200610111900.k9BJ01M4021853@hera.kernel.org> <452D4491.30806@garzik.org> <20061011122938.7e81f4bc@freekitty> <20061012000749.be62f2e0.akpm@osdl.org> <20061012102638.7381269a@freekitty> <20061013181922.GB721@stusta.de> X-Mailer: Sylpheed-Claws 2.5.3 (GTK+ 2.8.20; x86_64-redhat-linux-gnu) X-Face: &@E+xe?c%:&e4D{>f1O<&U>2qwRREG5!}7R4;D<"NO^UI2mJ[eEOA2*3>(`Th.yP,VDPo9$ /`~cw![cmj~~jWe?AHY7D1S+\}5brN0k*NE?pPh_'_d>6;XGG[\KDRViCfumZT3@[ Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1227 Lines: 40 On Fri, 13 Oct 2006 20:19:22 +0200 Adrian Bunk wrote: > On Thu, Oct 12, 2006 at 10:26:38AM -0700, Stephen Hemminger wrote: > > > > Make net_random() more widely available by calling it random32 > >... > > --- a/lib/Makefile > > +++ b/lib/Makefile > > @@ -5,7 +5,7 @@ # > > lib-y := ctype.o string.o vsprintf.o cmdline.o \ > > bust_spinlocks.o rbtree.o radix-tree.o dump_stack.o \ > > idr.o div64.o int_sqrt.o bitmap.o extable.o prio_tree.o \ > > - sha1.o irq_regs.o carta_random32.o > > + sha1.o irq_regs.o random32.o carta_random32.o > >... > > --- /dev/null > > +++ b/lib/random32.c > >... > > +EXPORT_SYMBOL(random32); > >... > > +EXPORT_SYMBOL(srandom32); > >... > > EXPORT_SYMBOL's in lib-y are latent bugs (IMHO kbuild should error > on them): > > The problem is that if only modules use these functions, they will be > omitted from the kernel image. > > cu > Adrian > The main net code uses the code so it isn't really an issue in this case. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/