Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1624811pxb; Mon, 12 Apr 2021 02:44:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytWalTCXU6g8tbdLi08fLlVOd3tvkQiGmwn0m6V4EkgqHYyhdWN8VQ3jyfjYYxz2oliuo1 X-Received: by 2002:a63:86c6:: with SMTP id x189mr50962pgd.264.1618220652991; Mon, 12 Apr 2021 02:44:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618220652; cv=none; d=google.com; s=arc-20160816; b=mRUX0SuBoUe4PLBhlvv1lQrUL7hunHCX6dOBmXl1n2FPtXzSdmDs45QFgjhj/D0bSt XYdk0982vgUALaVvSRxApt3C0Rc7TTbAxW3Om9GasYYw0X2pVSHR9oMxKpNsSfnEtPQQ rHITCeXTIChbngb9TDhLPquwBTP7aEtXlO7BzdQQw3YUsteqkasKzYw4HCNx3LCQu2nJ tS4tzcHumtIw583dAQs/otvCDY7gzil1mtSBRbF/FQNzMhYbpG8iC9tZ2pstmzu4HxnJ HTFlVk14ABSi1Rrt5XOufvOdq5IEcLbHiNZeqRpK4KlvVcrwmF2XoTuChwEDBLLCMUCy 2RcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=utRoWWOKyTRxRYYDNi+17U7ghOV/FOOu4eVOKntTKtU=; b=jLSJMVmr6agokOwsSj0OlYUShx5xYWKEEigUnq2X9SlYpLK1Fz6LKQBUg1SDSeUHTc mWVumlX9LbsUt+kEfScZzca/ZnQWOI2BKAQvKcgVJfcSjSzB8fUzc98vx9GMWReMy8LG dVVlEFhTOSxda3KQOQ9k8Dijpqg1NKBDF5JiRnlRhFc43Q+6tUHg0wYim3H3L52O5KGA LjwAHxRprqvSmQ2L3cpbbbN6n5pziL+FiMdDluPHj01LNAT6y96R+9Gy2iL00i5GZCVL yWVph/Z4tqvjGZcTjuJYAHWYc6u4eQz8L5YNl/gACSbEDwAyu6fhMi2xgIXerM91deuh 1Gfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=D+xwdxHx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d36si12277901pgd.553.2021.04.12.02.44.00; Mon, 12 Apr 2021 02:44:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=D+xwdxHx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242789AbhDLJk4 (ORCPT + 99 others); Mon, 12 Apr 2021 05:40:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:35928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240990AbhDLJLV (ORCPT ); Mon, 12 Apr 2021 05:11:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 208C5613D3; Mon, 12 Apr 2021 09:07:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618218471; bh=GIw+aTw5Z31LENcfguDz9+kPwPPK8Jkpsg252VjHhu8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D+xwdxHxeTsYAfjyHpECLvhVDvxMs+xXoKGrFpdQjgLYjwcZ6FsnXzk4Z1HHHo0W2 qf9q45lFQbwQYuXE7i8TcBd9xddVzxXXYoA7rBb6DR+XuvCHBp3s+ab51XZWhbfAQ2 B1IhJlmSs/m0+WpxiUhRhiOkJmdgQgYktKsf99HU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+d946223c2e751d136c94@syzkaller.appspotmail.com, Alexander Aring , Stefan Schmidt Subject: [PATCH 5.11 204/210] net: ieee802154: fix nl802154 del llsec dev Date: Mon, 12 Apr 2021 10:41:49 +0200 Message-Id: <20210412084022.784999657@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210412084016.009884719@linuxfoundation.org> References: <20210412084016.009884719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Aring commit 3d1eac2f45585690d942cf47fd7fbd04093ebd1b upstream. This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_DEVICE is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+d946223c2e751d136c94@syzkaller.appspotmail.com Signed-off-by: Alexander Aring Link: https://lore.kernel.org/r/20210221174321.14210-2-aahringo@redhat.com Signed-off-by: Stefan Schmidt Signed-off-by: Greg Kroah-Hartman --- net/ieee802154/nl802154.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/net/ieee802154/nl802154.c +++ b/net/ieee802154/nl802154.c @@ -1758,7 +1758,8 @@ static int nl802154_del_llsec_dev(struct struct nlattr *attrs[NL802154_DEV_ATTR_MAX + 1]; __le64 extended_addr; - if (nla_parse_nested_deprecated(attrs, NL802154_DEV_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVICE], nl802154_dev_policy, info->extack)) + if (!info->attrs[NL802154_ATTR_SEC_DEVICE] || + nla_parse_nested_deprecated(attrs, NL802154_DEV_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVICE], nl802154_dev_policy, info->extack)) return -EINVAL; if (!attrs[NL802154_DEV_ATTR_EXTENDED_ADDR])