Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1624829pxb; Mon, 12 Apr 2021 02:44:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPtPAavLb6UbYIGXcIUaDY9k9QAvzElo0M/pv3+JLPSjNYhdsnbU3R5dyAipWUy4asz+sw X-Received: by 2002:a17:90a:1d85:: with SMTP id v5mr13090410pjv.47.1618220654014; Mon, 12 Apr 2021 02:44:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618220654; cv=none; d=google.com; s=arc-20160816; b=P3mnIUrj98Hj3YMOQIFqmaTD2nUoaIT1dS3uwVSwsVJ3/nN1HA3lUayqNgvCgrR1Jh HFBdtxD/gXwNbFk/Mw6wRzudXoSo8RW/LnGaSiQyaE+JLba74HtaBcjeDPR1FNyaxjeB on2rNAKXldWvbxvUPdAArGoykn4gR8+wnAEDJfJpnS+ygL2WhcOPU5Cw+d3boqFcjdDp A33++6HL1TLY4yFeb4aAZ3CalRStpM3WemRHc41YyAhVZdYaI8vI78fAI7nMZRV0snvc ej7Yu1pkW5AIiVr93K55MBZkO4nkUlUv1njEFna3+1NRGjZtrxetocBeZkK173MakFN9 Yuwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GgvOh9fPci2NySg2EgLrwX8VRE6BwogGs2Qp/VQCZEg=; b=PvoAF92oQHs0KHymy8+7JRN/XUrEsj44XNaioDVxe25U1POHnuDQgacs5AhkHKwZkN jnhKA74D0TXiCplbRPQ5VZDCQYVwUqblLwcXntHs/CvcEgqMMdSn2Yl77Ls2MkrXsJ2z LGhgWOOfzcINiX+nKg3z9w4YU8MevjoVvVypD7QRwhU6YGIeWWE38H7aNogSQkLxXtxr FAx1+iY8dVjfI0krg+jv2wNiLe0LmXTAjoguXz/vAxl8wazbFnqE92qNPcrW8BeyGwev 4a+etRQTWaXFIozckHHjuWfjW929pSlqh7oi1qIrmS2JpamuYgftlYV1HIYb4KFSmYOg suDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=V9jljWGo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id in16si3312986pjb.30.2021.04.12.02.44.02; Mon, 12 Apr 2021 02:44:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=V9jljWGo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242089AbhDLJkJ (ORCPT + 99 others); Mon, 12 Apr 2021 05:40:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:34712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240902AbhDLJLJ (ORCPT ); Mon, 12 Apr 2021 05:11:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 16FA0613B7; Mon, 12 Apr 2021 09:07:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618218442; bh=pHHnBIH0H6q6wOCm2uT7Kf5bVgxyrSvcDT+UM+X8w58=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V9jljWGoaGM8N57OHpJ5/c6alWOxOlHjQ6QkcPzQruGXGEXwGsaJXoBUsP9iFxTyR 80JEJ1EbwOUiMMlpn8vkjGtJ0aguRpIgKsmJQ9hrlYROGmVBikRJ5bxNVfgPduvGxz wH+kLkqsnz3ihLCUKc+hc1wxu1GlanMxxIYeKxHQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+28a246747e0a465127f3@syzkaller.appspotmail.com, Pavel Skripkin , "David S. Miller" Subject: [PATCH 5.11 199/210] drivers: net: fix memory leak in atusb_probe Date: Mon, 12 Apr 2021 10:41:44 +0200 Message-Id: <20210412084022.630547941@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210412084016.009884719@linuxfoundation.org> References: <20210412084016.009884719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavel Skripkin commit 6b9fbe16955152626557ec6f439f3407b7769941 upstream. syzbot reported memory leak in atusb_probe()[1]. The problem was in atusb_alloc_urbs(). Since urb is anchored, we need to release the reference to correctly free the urb backtrace: [] kmalloc include/linux/slab.h:559 [inline] [] usb_alloc_urb+0x66/0xe0 drivers/usb/core/urb.c:74 [] atusb_alloc_urbs drivers/net/ieee802154/atusb.c:362 [inline][2] [] atusb_probe+0x158/0x820 drivers/net/ieee802154/atusb.c:1038 [1] Reported-by: syzbot+28a246747e0a465127f3@syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ieee802154/atusb.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/ieee802154/atusb.c +++ b/drivers/net/ieee802154/atusb.c @@ -365,6 +365,7 @@ static int atusb_alloc_urbs(struct atusb return -ENOMEM; } usb_anchor_urb(urb, &atusb->idle_urbs); + usb_free_urb(urb); n--; } return 0;