Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1626613pxb; Mon, 12 Apr 2021 02:47:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsIuLFQ98GxVss9zN+zeLNdRiFVNPiLXJsGI8G4DQ4PUB51QDO7K+o1UGJRtfF/uZOrK9b X-Received: by 2002:a17:90a:5903:: with SMTP id k3mr24489508pji.225.1618220843874; Mon, 12 Apr 2021 02:47:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618220843; cv=none; d=google.com; s=arc-20160816; b=lRlYKEFaweS4iUDYEKvSEYkD/zLXB5P9bjPCutR+4v4CtW+KWNIeg5GL6gfh5xvD3n imcp+eF4E0XGLH2Gk64lpM7D9jzg5VdjkKOXkJu1F+l6iufy83wYt9+FVt+Ihf7/g8Gh Ll5mu0CCq9YfiB8TfuQVHJwcf8U1I4Cvciz0Q1jFcAlzQ85HSz7Wi8z2euzzxdcirAP8 poDRwBlJXB5AMcGfBUP5lKHGCXqifHc3Kzw8p2gDSkvWv6c5+Fk6VJJHsydfX64hI5Ze R6+0f3PUeZqSQ//BG5DxinElXWwF5pZQsE6k1PL3nLK9y4leE6tZ/v01jNUoJQ6lGZdq X1lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SjqjJrSgoD+GM4eIeZt/pviY6oqIhN39WtDshWz7PHw=; b=zNgyfJseSOekgmXKkkyd2ceY/11s7bHSFmsS2oJQr/IxVuTkaRTqXmtNLeB8nTpPXz dKOBsZ2Xm0tKOC98eXRl/rLLLGPo9+qA8n1/uSO5wfxYaoQKJoNNBJBlMH8P06Prf5G2 +znlYM8Yq4vqDVKZK4tI5iZh/AYuIy3zfn3vpFXALnsLqT+bv0helA85PIqzBbYk3wTD VH76T/p9hWzuTj9kcSdEO4s6gRnTpdHAmflUxA8+geT6FNJEkRupWdG4tOpflKN+FLsO PCSbMa153wIj0yfSFGNrHCZcpbvm5WI2ZOsWfRfK1DWOfbDWMv2uJNFfqC+KNBce9TVV IOiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kn+cE0UD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ba10si5931678plb.414.2021.04.12.02.47.11; Mon, 12 Apr 2021 02:47:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kn+cE0UD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243047AbhDLJlN (ORCPT + 99 others); Mon, 12 Apr 2021 05:41:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:34456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241009AbhDLJLY (ORCPT ); Mon, 12 Apr 2021 05:11:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F2C196128C; Mon, 12 Apr 2021 09:08:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618218482; bh=m6Oub1k2Wh9ly8HF3jtsbb4Ph6qu7WqCG1PZbwA4cWw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kn+cE0UDrOuSJ51V5KScZ1z9+kqcqFIcSeYWRxo0b2N99mn+EcTlU4l9GdtdCS89x yjFs0/+zNeK05SvCAx7kgRqY5kLgcgGjrLH44mhyRBgOW8Ec7S9PJitBbvkE/731in xe28s4EcttCF7hfN/2EjHAMceU4NK+ArizTjUCIg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+fbf4fc11a819824e027b@syzkaller.appspotmail.com, Alexander Aring , Stefan Schmidt Subject: [PATCH 5.11 208/210] net: ieee802154: forbid monitor for del llsec seclevel Date: Mon, 12 Apr 2021 10:41:53 +0200 Message-Id: <20210412084022.929038358@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210412084016.009884719@linuxfoundation.org> References: <20210412084016.009884719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Aring commit 9dde130937e95b72adfae64ab21d6e7e707e2dac upstream. This patch forbids to del llsec seclevel for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Reported-by: syzbot+fbf4fc11a819824e027b@syzkaller.appspotmail.com Signed-off-by: Alexander Aring Link: https://lore.kernel.org/r/20210405003054.256017-15-aahringo@redhat.com Signed-off-by: Stefan Schmidt Signed-off-by: Greg Kroah-Hartman --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) --- a/net/ieee802154/nl802154.c +++ b/net/ieee802154/nl802154.c @@ -2092,6 +2092,9 @@ static int nl802154_del_llsec_seclevel(s struct wpan_dev *wpan_dev = dev->ieee802154_ptr; struct ieee802154_llsec_seclevel sl; + if (wpan_dev->iftype == NL802154_IFTYPE_MONITOR) + return -EOPNOTSUPP; + if (!info->attrs[NL802154_ATTR_SEC_LEVEL] || llsec_parse_seclevel(info->attrs[NL802154_ATTR_SEC_LEVEL], &sl) < 0)