Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1629735pxb; Mon, 12 Apr 2021 02:53:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdRfNOC+BjcTCitm4K5CBv3ddHCOMFGbNBu7A5FAmJqDpDP0HQSJi6G2SoxnLOX5r+YeW7 X-Received: by 2002:a17:906:5902:: with SMTP id h2mr26299513ejq.416.1618221190887; Mon, 12 Apr 2021 02:53:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618221190; cv=none; d=google.com; s=arc-20160816; b=KQ8h4cKVFQjq456d/cCv0lUcb3aE0K3B/XQJW3CBS7dx626n7BMo2AtwAFBFcC+bA+ 9blUZ/ILrEl/teB6ih8/tf4dR3gdKxOTSp33ZFCTbowGyyW9EpAl0oKEFU0WJOkcezcV y8yeICsSKWmauOUbyWUr14kHWbRI0KRAHpfCy10rhlyYZmjT43ygsM827PjyDRWTdKxU UhzJyn0N/mIol2UTK18YT5Sv9CykuXTIS2UI6ksH/bwaOdNuMOr+jIevdfGnux51sWO9 DaByN3CeW98E7oc3y7gEAmZZSNMR57Z9BInUtD7iDK+AR+Mv1OJmXPsbaW+PnMvQpqvh 62yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6JUGCN7ljcGJOxvas/EgKWl+1qxJfZ/EF0albfYObYQ=; b=m83XgJ7rXrWnmvCrxrKE1V/X3ViU2RWoa7h8QGjjVusAzbIgZkKZPBVFamIt7ySt8X IcVqfgov7PSv4VPe/wgEitBv3ZYMOVNtcTVU1o9A0n79AH/8/ckkXpKiHYR8MOaYe8Qn zpT3AQFt+UVewQsTPW6TPqNTCX0a5Slmez9WbconCI1lLnk5xYujyphcWOlDt3kBBSfR jbdEXEmvP/YppffyfsclW4dEVzm8uv4S3Bs5mSfQ77+xgUz8IKVoO3bjYaqkpSgMH4xx UKb8MZb9eaFs3vOQWwZkf9Q8cm6I71sr38HNvN9O4TynmykfhIEg988swwXFA7lVCVlb FvOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=b6gCbW6m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m26si7632558edv.514.2021.04.12.02.52.42; Mon, 12 Apr 2021 02:53:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=b6gCbW6m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242232AbhDLJqS (ORCPT + 99 others); Mon, 12 Apr 2021 05:46:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:49350 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239861AbhDLJbm (ORCPT ); Mon, 12 Apr 2021 05:31:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6D9B16120B; Mon, 12 Apr 2021 09:31:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618219877; bh=KFyKD4Fg+N+TvNqJOb+mIemp9paR8DOXakCsnemb9XY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b6gCbW6mvQDZpUGpIRg7p1fKvDiz+EN4TDLZ5CvhHI90uzE2pugP+sl6WmkdV8bj8 llLeBGMJuD6jN+octzWZAVOO4iy2P+KAsIlALHkk6JIQ78cPbf5Q4E+drTcUmw4Zfp DYxkpx7VSRshgM7S8lCLpVWp1fT2kBHz3f6rZh8c= Date: Mon, 12 Apr 2021 11:31:15 +0200 From: Greg KH To: "Fabio M. De Francesco" Cc: outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8192u: Remove variable set but not used Message-ID: References: <20210411174143.31618-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210411174143.31618-1-fmdefrancesco@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 11, 2021 at 07:41:43PM +0200, Fabio M. De Francesco wrote: > Remove variable "int ret" which is instantiated but not used. > > Signed-off-by: Fabio M. De Francesco > --- > drivers/staging/rtl8192u/r8192U_core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c > index f48186a89fa1..30055de66239 100644 > --- a/drivers/staging/rtl8192u/r8192U_core.c > +++ b/drivers/staging/rtl8192u/r8192U_core.c > @@ -902,7 +902,6 @@ static void rtl8192_hard_data_xmit(struct sk_buff *skb, struct net_device *dev, > int rate) > { > struct r8192_priv *priv = (struct r8192_priv *)ieee80211_priv(dev); > - int ret; > unsigned long flags; > struct cb_desc *tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE); > u8 queue_index = tcb_desc->queue_index; > -- > 2.31.1 > > Did you test-build this patch?