Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751902AbWJMU7t (ORCPT ); Fri, 13 Oct 2006 16:59:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751909AbWJMU7t (ORCPT ); Fri, 13 Oct 2006 16:59:49 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:53266 "HELO iolanthe.rowland.org") by vger.kernel.org with SMTP id S1751902AbWJMU7s (ORCPT ); Fri, 13 Oct 2006 16:59:48 -0400 Date: Fri, 13 Oct 2006 16:59:45 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Matthew Wilcox cc: Alan Cox , Adam Belay , Arjan van de Ven , Benjamin Herrenschmidt , Greg KH , , Linux-pm mailing list , Kernel development list Subject: Re: [linux-pm] Bug in PCI core In-Reply-To: <20061013191854.GF11633@parisc-linux.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 932 Lines: 23 On Fri, 13 Oct 2006, Matthew Wilcox wrote: > On Fri, Oct 13, 2006 at 01:57:48PM -0400, Alan Stern wrote: > > Would it be okay for pci_block_user_cfg_access() to use its own cache, so > > it doesn't interfere with data previously cached by pci_save_state()? > > My suggestion is just to require that the callers have previously called > pci_save_state(). The PCI PM stack already has, and it's a one-line > change to the IPR driver. Okay. Would you like to write a patch with that fix? Be sure to add a comment explaining the need for a previous call to pci_save_state(). At least it will get things going for now, even if it isn't perfectly correct in the long run. Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/