Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1632333pxb; Mon, 12 Apr 2021 02:58:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznLPzytGMAZuvfO1kDGfcOEvmFRRoHNsf5+yG3laz2nNt7Bvm0FbkAID034jhBLYyUYDs5 X-Received: by 2002:a17:90b:1b4e:: with SMTP id nv14mr24664548pjb.228.1618221499670; Mon, 12 Apr 2021 02:58:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618221499; cv=none; d=google.com; s=arc-20160816; b=V8F+K92BDN7ur4OFpV9fh+tlNkEgjP+MWzIg3I+feulx3rEeI136Dh7Vrgdm1FHwpW I03tu3JLvcu2MW1g/2LZqRXg/pi6aUoVJT7VeXxn/yWFcFqQKynjkOi3dX8wjXkJE+wX /YYLHowaORUr/+2ndsAX6ES9hjqq2X62wRgieF4ycpI85R+CqtBXCwB5iDNv6hclOjRQ IS6JfdvRyCacxBpyLA0slaKK9f0+1R2y7nkOTaPT0YQZfRFtJzHpfjNS5MK6yYjj21fh XNpJx50iSWdoSM8fI88kz4klhkDK5uHgFtJYszRTZ8K0k+UTeTzn9y1diIIIpCwvQN82 n9cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qqZeGjx9JkO+j6ssD42oeQMufXKDTYpwZFaRZOlqNzA=; b=fwnVx+XG9t3FUAR6Qo5TWfE2cP6z7a7BxPpsTN4LGW8jSp5WL3CN7ZfMFWq9mcMFyU gbA+KviZufXi3OAUb86zXcjgTVWBlO6sxxtkBS8KGUhBN7WyDg+b+X+XcM0uxekQDBLk y69dK0IQy8Z1M6vs2moi+gfDCQUS2Bp0hNpyqQdfRffJf5UEdXJAkm8N7GkVkbiRhyxr HcUdz5OfDXZaNmBKaW37cTIiLkCEDPJXO8J2Z4RrWkO0+hWvSDzxjEKU3bGKTRFfEYzm 819IfS0heK0goPj/hPScNoZG27Cumyq6GacszwlcRPZxnv4R0d6giIqeY86DcVRriovq K+yQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JtcfxJvk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ba10si5931691plb.414.2021.04.12.02.58.07; Mon, 12 Apr 2021 02:58:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JtcfxJvk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239944AbhDLJxF (ORCPT + 99 others); Mon, 12 Apr 2021 05:53:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:56412 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243070AbhDLJlQ (ORCPT ); Mon, 12 Apr 2021 05:41:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EA17C61221; Mon, 12 Apr 2021 09:40:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618220458; bh=doYnKmWvvFZJu0dQidagDHHTL22R/NmtwWLIsanGgmU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JtcfxJvkAh1LM3t2ai/DSDFLRAA6MPqSI+Ve/dsqSdGJvuLkEKl+w9R2ME2AH4k9a PROhYB7hanmdap0MPlr+YjZo1qhcSy1tVyCqIMx4zVGv+tYh4VA+ITiaiTcB82GMbw QOn3eJ9ng+gcFK+ARmI8isTGydvZaHoWDrXyFH0eaRy/hrgtA1CX8C5v1UQ+KD+lyN f/tUS9QRAlsbvE+q3XQrhQ2jxVi0rwhwybM28Nv5SeLUdZO9+l0Wbq0KbJQ1yyKKJg 2YovP1KNQ0mT6mgUSUMM3+5OMZbxA0gGxhKefXOSbTLXijLuFFr8bBMcmdUTWU9lhj Ihl1EX/TbOWiA== Date: Mon, 12 Apr 2021 15:10:54 +0530 From: Vinod Koul To: Dinghao Liu Cc: kjlu@umn.edu, Laxman Dewangan , Jon Hunter , Thierry Reding , dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] dmaengine: tegra20: Fix runtime PM imbalance on error Message-ID: References: <20210409082805.23643-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210409082805.23643-1-dinghao.liu@zju.edu.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09-04-21, 16:28, Dinghao Liu wrote: > pm_runtime_get_sync() will increase the runtime PM counter > even it returns an error. Thus a pairing decrement is needed > to prevent refcount leak. Fix this by replacing this API with > pm_runtime_resume_and_get(), which will not change the runtime > PM counter on error. Applied, thanks -- ~Vinod